Prev: [PATCH 10/16] x86, memblock: Add memblock_x86_memory_in_range()
Next: Staging: vt6656: Remove PUINT from ttype.h
From: Greg KH on 22 Jul 2010 14:50
On Thu, Jul 22, 2010 at 01:07:53PM -0400, Chihau Chau wrote:
> From: Chihau Chau <chihau(a)gmail.com>
>
> This fix some lines over 80 characters.
>
> Signed-off-by: Chihau Chau <chihau(a)gmail.com>
> ---
> drivers/staging/comedi/drivers.c | 17 ++++++++---------
> 1 files changed, 8 insertions(+), 9 deletions(-)
>
> diff --git a/drivers/staging/comedi/drivers.c b/drivers/staging/comedi/drivers.c
> index 4a29ed7..50c8295 100644
> --- a/drivers/staging/comedi/drivers.c
> +++ b/drivers/staging/comedi/drivers.c
> @@ -117,8 +117,8 @@ int comedi_device_attach(struct comedi_device *dev, struct comedi_devconfig *it)
>
> for (driv = comedi_drivers; driv; driv = driv->next) {
> if (!try_module_get(driv->module)) {
> - printk
> - (KERN_INFO "comedi: failed to increment module count, skipping\n");
> + printk(KERN_INFO "comedi: failed to increment module "
> + "count, skipping\n");

No, please don't break strings across lines like this, it makes it
harder to grep for things.

How about something like:
printk(KERN_INFO "comedi: failed to increment module count, skipping\n");
instead. That should pass the checkpatch.pl script, right?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
 | 
Pages: 1
Prev: [PATCH 10/16] x86, memblock: Add memblock_x86_memory_in_range()
Next: Staging: vt6656: Remove PUINT from ttype.h