Staging: dt3155: properly export the module parameter
in [Kernel]
|
Prev: [GIT PULL] kgdb regression fixes for 2.6.35-rc5
Next: alpha: Implement HW performance events on the EV67 and later CPUs.
From: Jiri Slaby on 28 Jul 2010 17:00 On 07/28/2010 06:48 PM, H Hartley Sweeten wrote: > Make the module parameter dt3155_major static and add the proper > wrappers to export it. > > Signed-off-by: H Hartley Sweeten <hsweeten(a)visionengravers.com> > Cc: Greg Kroah-Hartman <gregkh(a)suse.de> > Cc: Scott Smedley <ss(a)aao.gov.au> > --- > > diff --git a/drivers/staging/dt3155/dt3155_drv.c b/drivers/staging/dt3155/dt3155_drv.c > index 7316996..220eaf9 100644 > --- a/drivers/staging/dt3155/dt3155_drv.c > +++ b/drivers/staging/dt3155/dt3155_drv.c > @@ -99,7 +99,9 @@ wait_queue_head_t dt3155_read_wait_queue[MAXBOARDS]; > > /* set to dynamicaly allocate, but it is tunable: */ > /* insmod DT_3155 dt3155 dt3155_major=XX */ > -int dt3155_major = 0; > +static int dt3155_major; > +module_param(dt3155_major, int, 0); > +MODULE_PARM_DESC(dt3155_major, "Major device number"); Is it necessary in the age of udev? I would personally get rid of that completely... regards, -- js -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: H Hartley Sweeten on 28 Jul 2010 21:00 On Wednesday, July 28, 2010 1:59 PM, Jiri Slaby wrote: > On 07/28/2010 06:48 PM, H Hartley Sweeten wrote: >> Make the module parameter dt3155_major static and add the proper >> wrappers to export it. >> >> Signed-off-by: H Hartley Sweeten <hsweeten(a)visionengravers.com> >> Cc: Greg Kroah-Hartman <gregkh(a)suse.de> >> Cc: Scott Smedley <ss(a)aao.gov.au> >> --- >> >> diff --git a/drivers/staging/dt3155/dt3155_drv.c b/drivers/staging/dt3155/dt3155_drv.c >> index 7316996..220eaf9 100644 >> --- a/drivers/staging/dt3155/dt3155_drv.c >> +++ b/drivers/staging/dt3155/dt3155_drv.c >> @@ -99,7 +99,9 @@ wait_queue_head_t dt3155_read_wait_queue[MAXBOARDS]; >> >> /* set to dynamicaly allocate, but it is tunable: */ >> /* insmod DT_3155 dt3155 dt3155_major=XX */ >> -int dt3155_major = 0; >> +static int dt3155_major; >> +module_param(dt3155_major, int, 0); >> +MODULE_PARM_DESC(dt3155_major, "Major device number"); > > Is it necessary in the age of udev? > > I would personally get rid of that completely... I agree but I'm not quite sure if the user space app is ready to handle that. Scott, can you provide any input? Regards, Hartley-- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Jiri Slaby on 29 Jul 2010 09:10 On 07/29/2010 02:55 AM, H Hartley Sweeten wrote: > On Wednesday, July 28, 2010 1:59 PM, Jiri Slaby wrote: >> On 07/28/2010 06:48 PM, H Hartley Sweeten wrote: >>> --- a/drivers/staging/dt3155/dt3155_drv.c >>> +++ b/drivers/staging/dt3155/dt3155_drv.c >>> @@ -99,7 +99,9 @@ wait_queue_head_t dt3155_read_wait_queue[MAXBOARDS]; >>> >>> /* set to dynamicaly allocate, but it is tunable: */ >>> /* insmod DT_3155 dt3155 dt3155_major=XX */ >>> -int dt3155_major = 0; >>> +static int dt3155_major; >>> +module_param(dt3155_major, int, 0); >>> +MODULE_PARM_DESC(dt3155_major, "Major device number"); >> >> Is it necessary in the age of udev? >> >> I would personally get rid of that completely... > > I agree but I'm not quite sure if the user space app is ready to handle that. Given it was never exposed as a parameter, applications should handle that. 0 means allocate major dynamically... regards, -- js -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: H Hartley Sweeten on 29 Jul 2010 12:10 On Thursday, July 29, 2010 6:09 AM, Jiri Slaby wrote: > On 07/29/2010 02:55 AM, H Hartley Sweeten wrote: >> On Wednesday, July 28, 2010 1:59 PM, Jiri Slaby wrote: >>> On 07/28/2010 06:48 PM, H Hartley Sweeten wrote: >>>> --- a/drivers/staging/dt3155/dt3155_drv.c >>>> +++ b/drivers/staging/dt3155/dt3155_drv.c >>>> @@ -99,7 +99,9 @@ wait_queue_head_t dt3155_read_wait_queue[MAXBOARDS]; >>>> >>>> /* set to dynamicaly allocate, but it is tunable: */ >>>> /* insmod DT_3155 dt3155 dt3155_major=XX */ >>>> -int dt3155_major = 0; >>>> +static int dt3155_major; >>>> +module_param(dt3155_major, int, 0); >>>> +MODULE_PARM_DESC(dt3155_major, "Major device number"); >>> >>> Is it necessary in the age of udev? >>> >>> I would personally get rid of that completely... >> >> I agree but I'm not quite sure if the user space app is ready to handle that. > > Given it was never exposed as a parameter, applications should handle > that. 0 means allocate major dynamically... Understood. I finally found the "official" site for the "DT3155 Framegrabber Linux Device Driver" http://sourceforge.net/projects/dt3155a/ The script provided to load the module does grep /proc/devices to determine the major device number and then mknod's the appropriate devices. I will update my patch and remove the "parameter" since it is not needed. Thanks, Hartley-- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Greg KH on 2 Aug 2010 21:10
On Thu, Jul 29, 2010 at 11:02:38AM -0500, H Hartley Sweeten wrote: > On Thursday, July 29, 2010 6:09 AM, Jiri Slaby wrote: > > On 07/29/2010 02:55 AM, H Hartley Sweeten wrote: > >> On Wednesday, July 28, 2010 1:59 PM, Jiri Slaby wrote: > >>> On 07/28/2010 06:48 PM, H Hartley Sweeten wrote: > >>>> --- a/drivers/staging/dt3155/dt3155_drv.c > >>>> +++ b/drivers/staging/dt3155/dt3155_drv.c > >>>> @@ -99,7 +99,9 @@ wait_queue_head_t dt3155_read_wait_queue[MAXBOARDS]; > >>>> > >>>> /* set to dynamicaly allocate, but it is tunable: */ > >>>> /* insmod DT_3155 dt3155 dt3155_major=XX */ > >>>> -int dt3155_major = 0; > >>>> +static int dt3155_major; > >>>> +module_param(dt3155_major, int, 0); > >>>> +MODULE_PARM_DESC(dt3155_major, "Major device number"); > >>> > >>> Is it necessary in the age of udev? > >>> > >>> I would personally get rid of that completely... > >> > >> I agree but I'm not quite sure if the user space app is ready to handle that. > > > > Given it was never exposed as a parameter, applications should handle > > that. 0 means allocate major dynamically... > > Understood. > > I finally found the "official" site for the "DT3155 Framegrabber Linux Device Driver" > > http://sourceforge.net/projects/dt3155a/ > > The script provided to load the module does grep /proc/devices to determine the major > device number and then mknod's the appropriate devices. > > I will update my patch and remove the "parameter" since it is not needed. As there is another driver already in the tree for this device, dt3155v4l, I'm about to delete the dt3155 driver as it's no longer needed. So you might want to reconsider your work on this driver for the near future. thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ |