Prev: MAIL DETAILS.
Next: [GIT PULL 0/3] perf annotate improvements, report fix
From: Charles Clément on 22 May 2010 13:40
Hello Timofey,

I think the message you send should have the Signed-off-by in the body,
as well as the long description of the patch.

On Sat, May 22, 2010 at 08:42:54PM +0400, Timofey Trofimov wrote:
> ---
> drivers/staging/vt6656/80211mgr.c | 514 ++++++++++++++++++-------------------
> 1 files changed, 251 insertions(+), 263 deletions(-)
>
> diff --git a/drivers/staging/vt6656/80211mgr.c b/drivers/staging/vt6656/80211mgr.c
> index f24dc55..7236019 100644
> --- a/drivers/staging/vt6656/80211mgr.c
> +++ b/drivers/staging/vt6656/80211mgr.c
> @@ -67,8 +67,8 @@
>
> /*--------------------- Static Variables --------------------------*/
>
> -static int msglevel =MSG_LEVEL_INFO;
> -//static int msglevel =MSG_LEVEL_DEBUG;
> +static int msglevel = MSG_LEVEL_INFO;
> +/*static int msglevel =MSG_LEVEL_DEBUG;*/
> /*--------------------- Static Functions --------------------------*/

Here, even if the code is commented you could add the extra space, in
case the code is uncommented later.

Charles.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: Charles Clément on 22 May 2010 20:00
Hey,

On Sat, May 22, 2010 at 09:52:25PM +0400, Тимофей Трофимов wrote:
> Hi, Charles. I understand what I did wrong and never will make this
> mistake mistake again. I really thought that I write this. Sorry.
> P.S. This is my first patch. Does I need to resend it?

I think you should try to resend it, at least to get the subject line
and body correct, you can try that by sending it only to yourself first.

I should also point out that the discussion should remain on the
corresponding mailing lists.

--
Charles Clément

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: Greg KH on 24 May 2010 14:50
On Sat, May 22, 2010 at 04:53:32PM -0700, Charles Clément wrote:
> Hey,
>
> On Sat, May 22, 2010 at 09:52:25PM +0400, Тимофей Трофимов wrote:
> > Hi, Charles. I understand what I did wrong and never will make this
> > mistake mistake again. I really thought that I write this. Sorry.
> > P.S. This is my first patch. Does I need to resend it?
>
> I think you should try to resend it, at least to get the subject line
> and body correct, you can try that by sending it only to yourself first.

It's ok, it's a common mistake combined with a bug in git-format-patch.
I can handle this just fine, don't worry about it.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
 | 
Pages: 1
Prev: MAIL DETAILS.
Next: [GIT PULL 0/3] perf annotate improvements, report fix