Prev: [HACKERS] A thought: should we run pgindent now?
Next: A thought: should we run pgindent now?
From: Heikki Linnakangas on 18 Feb 2010 06:14
Fujii Masao wrote:
> * The received byte is stored in *c. Returns 1 if a byte was read, 0 if
> ! * if no data was available, or EOF if trouble.
>
> Typo. 'if' is repeated.
>
>
> + ereport(COMMERROR,
> + (errcode_for_socket_access(),
> + errmsg("could not receive data from client: %m")));
> + return EOF;
>
> We should use "r = EOF" instead of "return EOF" as well as other cases?

Yep.

> In WalSndHandshake(), when pq_getbyte() returns EOF, the COMMERROR message
> "unexpected EOF on standby connection" is emitted doubly. How about removing
> first COMMERROR message?

Yep.

> r = pq_getbyte_if_available(&firstchar);
> if (r < 0)
> {
> ! /* unexpected error */
> ereport(COMMERROR,
> ! (errcode(ERRCODE_PROTOCOL_VIOLATION),
> ! errmsg("unexpected EOF on standby connection")));
> ! proc_exit(0);
> }
>
> Since pq_getbyte_if_available() returns EOF if trouble, "r == EOF" should
> be used instead of "r < 0"?

Yep.

Committed with all those fixes.

--
Heikki Linnakangas
EnterpriseDB http://www.enterprisedb.com

--
Sent via pgsql-hackers mailing list (pgsql-hackers(a)postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

First  |  Prev  | 
Pages: 1 2
Prev: [HACKERS] A thought: should we run pgindent now?
Next: A thought: should we run pgindent now?