Streaming replication, loose ends
in [PgSql]
|
From: Bruce Momjian on 15 Jan 2010 05:36 Heikki Linnakangas wrote: > I've now committed streaming replication. I moved the files around a > bit, and put the walreceiver/walsender stuff in a new > src/backend/replication subdirectory. There's enough stuff there already > to deserve a new subdirectory, and if we add the capability for > streaming base backups etc. that has been discussed, we will have more > code in there. > > But it's not time to party yet. There's still a few loose ends we need > to address: > > Documentation. The patch originally moved around some sections, but I > didn't include that in the committed version, to make it clear in the > diff what exactly was added/changed. But I do agree with the original > thought of adding a new "Replication" chapter, and moving all the > replication and standby related stuff there from the "Backup and > Restore" chapter, so let's start working on that. Uh, do we really want to call this "replication" rather than archive log streaming or something. It seems "replication" is a generic term and will confuse people who are using other replication solutions like Slony. -- Bruce Momjian <bruce(a)momjian.us> http://momjian.us EnterpriseDB http://enterprisedb.com + If your life is a hard drive, Christ can be your backup. + -- Sent via pgsql-hackers mailing list (pgsql-hackers(a)postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
From: Pavel Stehule on 15 Jan 2010 05:44 2010/1/15 Bruce Momjian <bruce(a)momjian.us>: > Heikki Linnakangas wrote: >> I've now committed streaming replication. I moved the files around a >> bit, and put the walreceiver/walsender stuff in a new >> src/backend/replication subdirectory. There's enough stuff there already >> to deserve a new subdirectory, and if we add the capability for >> streaming base backups etc. that has been discussed, we will have more >> code in there. >> >> But it's not time to party yet. There's still a few loose ends we need >> to address: >> >> Documentation. The patch originally moved around some sections, but I >> didn't include that in the committed version, to make it clear in the >> diff what exactly was added/changed. But I do agree with the original >> thought of adding a new "Replication" chapter, and moving all the >> replication and standby related stuff there from the "Backup and >> Restore" chapter, so let's start working on that. > > Uh, do we really want to call this "replication" rather than archive log > streaming or something.  It seems "replication" is a generic term and > will confuse people who are using other replication solutions like > Slony. +1 Pavel > > -- >  Bruce Momjian  <bruce(a)momjian.us>     http://momjian.us >  EnterpriseDB               http://enterprisedb.com > >  + If your life is a hard drive, Christ can be your backup. + > > -- > Sent via pgsql-hackers mailing list (pgsql-hackers(a)postgresql.org) > To make changes to your subscription: > http://www.postgresql.org/mailpref/pgsql-hackers > -- Sent via pgsql-hackers mailing list (pgsql-hackers(a)postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
From: Boszormenyi Zoltan on 15 Jan 2010 06:09 Hi, Heikki Linnakangas �rta: > I've now committed streaming replication. I moved the files around a > bit, and put the walreceiver/walsender stuff in a new > src/backend/replication subdirectory. [snip] there's one loose end indeed. "make maintainer-clean" doesn't delete these: src/backend/replication/walreceiver/walreceiver.o src/backend/replication/walreceiver/walreceiver.so src/backend/replication/walreceiver/.deps/ Best regards, Zolt�n B�sz�rm�nyi -- Bible has answers for everything. Proof: "But let your communication be, Yea, yea; Nay, nay: for whatsoever is more than these cometh of evil." (Matthew 5:37) - basics of digital technology. "May your kingdom come" - superficial description of plate tectonics ---------------------------------- Zolt�n B�sz�rm�nyi Cybertec Sch�nig & Sch�nig GmbH http://www.postgresql.at/ -- Sent via pgsql-hackers mailing list (pgsql-hackers(a)postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
From: Heikki Linnakangas on 15 Jan 2010 07:27 Boszormenyi Zoltan wrote: > Heikki Linnakangas �rta: >> I've now committed streaming replication. I moved the files around a >> bit, and put the walreceiver/walsender stuff in a new >> src/backend/replication subdirectory. [snip] > > there's one loose end indeed. > "make maintainer-clean" doesn't delete these: > > src/backend/replication/walreceiver/walreceiver.o > src/backend/replication/walreceiver/walreceiver.so > src/backend/replication/walreceiver/.deps/ Hmm, I think I'm going to need some help with the Makefiles. Clearly the way I hooked that directory to the build system was wrong. I think the attached patch will fix that, but I wonder if there's a trick I'm missing. Do the MSVC scripts need adjusting? 'red_bat' compiled fine, so I guess not. Also, I'm seeing a failure in buildfarm member 'colugos': /opt/local/bin/ccache /Developer/usr/bin/llvm-gcc-4.2 -no-cpp-precomp -I/opt/local/include -Wall -Wmissing-prototypes -Wpointer-arith -Wdeclaration-after-statement -Wendif-labels -fno-strict-aliasing -fwrapv -g -bundle -multiply_defined suppress walreceiver.o -bundle_loader ../../../../src/backend/postgres -L../../../../src/interfaces/libpq -L../../../../src/port -L/opt/local/lib -lpq -o walreceiver.so ld: library not found for -lpq collect2: ld returned 1 exit status make[2]: *** [walreceiver.so] Error 1 make[2]: *** Waiting for unfinished jobs.... I suspect that's because libpq isn't built yet. I have this: > all: submake-libpq all-shared-lib in src/backend/replication/walreceiver/Makefile, but is that not enough? -- Heikki Linnakangas EnterpriseDB http://www.enterprisedb.com
From: Heikki Linnakangas on 15 Jan 2010 08:59 Heikki Linnakangas wrote: > Also, I'm seeing a failure in buildfarm member 'colugos': > > /opt/local/bin/ccache /Developer/usr/bin/llvm-gcc-4.2 -no-cpp-precomp > -I/opt/local/include -Wall -Wmissing-prototypes -Wpointer-arith > -Wdeclaration-after-statement -Wendif-labels -fno-strict-aliasing > -fwrapv -g -bundle -multiply_defined suppress walreceiver.o > -bundle_loader ../../../../src/backend/postgres > -L../../../../src/interfaces/libpq -L../../../../src/port > -L/opt/local/lib -lpq -o walreceiver.so > ld: library not found for -lpq > collect2: ld returned 1 exit status > make[2]: *** [walreceiver.so] Error 1 > make[2]: *** Waiting for unfinished jobs.... > > I suspect that's because libpq isn't built yet. I have this: > >> all: submake-libpq all-shared-lib > > in src/backend/replication/walreceiver/Makefile, but is that not enough? Yep. What's happening is that "make -j" starts building libpq and walreceiver.so simultaneously, because of the above line in the Makefile. We actually have the same problem in src/bin/*/Makefile, but we don't notice it there because src/interfaces is listed before src/bin in src/Makefile, so when you do "make -j" at the top-level, libpq is built first. You get the same error if you do "make clean" at the top-level, and then e.g "cd src/bin/scripts/; make -j" So the simple fix would be to reorder the lines in src/Makefile, so that src/interfaces is built before src/backend. Alternatively we could do this: *** src/backend/replication/walreceiver/Makefile 15 Jan 2010 09:19:03 -0000 1.1 --- src/backend/replication/walreceiver/Makefile 15 Jan 2010 13:57:24 -0000 *************** *** 18,24 **** SHLIB_LINK = $(libpq) NAME = walreceiver ! all: submake-libpq all-shared-lib include $(top_srcdir)/src/Makefile.shlib --- 18,28 ---- SHLIB_LINK = $(libpq) NAME = walreceiver ! all: all-shared-lib ! ! # Compiling walreceiver.o doesn't really need libpq library, ! # only linking it does. But there's no easy way to specify that. ! walreceiver.o: submake-libpq include $(top_srcdir)/src/Makefile.shlib And I guess all the other uses of submake-libpq should be changed similarly. Am I missing a trick? -- Heikki Linnakangas EnterpriseDB http://www.enterprisedb.com -- Sent via pgsql-hackers mailing list (pgsql-hackers(a)postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
|
Next
|
Last
Pages: 1 2 3 4 5 Prev: attoptions Next: [HACKERS] missing data in information_schema grant_* tables? |