From: Eric Dumazet on 30 May 2010 17:20 Le dimanche 30 mai 2010 à 23:09 +0200, Julia Lawall a écrit : > could exit with success without the kzalloc ever being called. If the > kzalloc is moved up, it could fail and then it returns immediately without > executing the loop. A solution could be to leave the NULL test on p where > it is, and only move up the kzalloc. Or perhaps the change in behavior > doesn't matter? If a GFP_KERNEL allocation fails, we are in a big trouble anyway :) GFP_ATOMIC are more problematic in this area :) -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
First
|
Prev
|
Pages: 1 2 Prev: [GIT PULL] mutex fix Next: [PATCH 1/3] kernel: Use GFP_ATOMIC when a lock is held |