Support kernel/hotplug sysctl variable when !CONFIG_NET
in [Kernel]
|
From: Ian Abbott on 7 Jun 2010 08:20 On 07/06/10 12:57, Ian Abbott wrote: > The kernel/hotplug sysctl variable (/proc/sys/kernel/hotplug file) was ^^^^^^^^^^^^^^ That should read "kernel.hotplug" of course! -- -=( Ian Abbott @ MEV Ltd. E-mail: <abbotti(a)mev.co.uk> )=- -=( Tel: +44 (0)161 477 1898 FAX: +44 (0)161 718 3587 )=- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Greg KH on 7 Jun 2010 13:50 On Mon, Jun 07, 2010 at 12:57:12PM +0100, Ian Abbott wrote: > From: Ian Abbott <abbotti(a)mev.co.uk> > > The kernel/hotplug sysctl variable (/proc/sys/kernel/hotplug file) was > made conditional on CONFIG_NET by commit > f743ca5e10f4145e0b3e6d11b9b46171e16af7ce (applied in 2.6.18) to fix > problems with undefined references in 2.6.16 when CONFIG_HOTPLUG=y && > !CONFIG_NET, but this restriction is no longer needed. Why is this restriction no longer needed? What changed? > This patch makes the kernel/hotplug sysctl variable depend only on > CONFIG_HOTPLUG. Why is this needed? Are you really running without a network and still want to change the default /sbin/hotplug binary? confused, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Randy Dunlap on 7 Jun 2010 14:20 On Mon, 7 Jun 2010 10:43:50 -0700 Greg KH wrote: > On Mon, Jun 07, 2010 at 12:57:12PM +0100, Ian Abbott wrote: > > From: Ian Abbott <abbotti(a)mev.co.uk> > > > > The kernel/hotplug sysctl variable (/proc/sys/kernel/hotplug file) was > > made conditional on CONFIG_NET by commit > > f743ca5e10f4145e0b3e6d11b9b46171e16af7ce (applied in 2.6.18) to fix > > problems with undefined references in 2.6.16 when CONFIG_HOTPLUG=y && > > !CONFIG_NET, but this restriction is no longer needed. Ack, builds for me on x86_64 when CONFIG_NET is not enabled. > Why is this restriction no longer needed? What changed? commit cd3772e6898c6386f21d2958346d6dd57d4204f5 Author: Ming Lei <tom.leiming(a)gmail.com> Date: Sun Nov 16 18:22:09 2008 +0800 kernel/ksysfs.c:fix dependence on CONFIG_NET Access to uevent_seqnum and uevent_helper does not need to depend on CONFIG_NET, so remove it. Signed-off-by: Ming Lei <tom.leiming(a)gmail.com> Cc: Kay Sievers <kay.sievers(a)vrfy.org> Signed-off-by: Greg Kroah-Hartman <gregkh(a)suse.de> > > This patch makes the kernel/hotplug sysctl variable depend only on > > CONFIG_HOTPLUG. > > Why is this needed? Are you really running without a network and still > want to change the default /sbin/hotplug binary? > > confused, --- ~Randy *** Remember to use Documentation/SubmitChecklist when testing your code *** -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Randy Dunlap on 7 Jun 2010 14:30 On 06/07/10 11:16, Greg KH wrote: > On Mon, Jun 07, 2010 at 11:11:45AM -0700, Randy Dunlap wrote: >> On Mon, 7 Jun 2010 10:43:50 -0700 Greg KH wrote: >> >>> On Mon, Jun 07, 2010 at 12:57:12PM +0100, Ian Abbott wrote: >>>> From: Ian Abbott <abbotti(a)mev.co.uk> >>>> >>>> The kernel/hotplug sysctl variable (/proc/sys/kernel/hotplug file) was >>>> made conditional on CONFIG_NET by commit >>>> f743ca5e10f4145e0b3e6d11b9b46171e16af7ce (applied in 2.6.18) to fix >>>> problems with undefined references in 2.6.16 when CONFIG_HOTPLUG=y && >>>> !CONFIG_NET, but this restriction is no longer needed. >> >> Ack, builds for me on x86_64 when CONFIG_NET is not enabled. >> >>> Why is this restriction no longer needed? What changed? >> >> >> commit cd3772e6898c6386f21d2958346d6dd57d4204f5 >> Author: Ming Lei <tom.leiming(a)gmail.com> >> Date: Sun Nov 16 18:22:09 2008 +0800 >> >> kernel/ksysfs.c:fix dependence on CONFIG_NET >> >> Access to uevent_seqnum and uevent_helper does not need to >> depend on CONFIG_NET, so remove it. >> >> Signed-off-by: Ming Lei <tom.leiming(a)gmail.com> >> Cc: Kay Sievers <kay.sievers(a)vrfy.org> >> Signed-off-by: Greg Kroah-Hartman <gregkh(a)suse.de> > > So something back in 2008 changed which requires a change now? "requires" is too strong of a word to use here. "allows" a change. > I'm still confused, what use case calls for the original patch here > being made? Who wants to modify this option with CONFIG_NET disabled on > their machine? Are you trying to slow down on kernel patches for some reason? Using CONFIG_NET is more restrictive than is needed here, so remove it. -- ~Randy *** Remember to use Documentation/SubmitChecklist when testing your code *** -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Greg KH on 7 Jun 2010 14:30 On Mon, Jun 07, 2010 at 11:11:45AM -0700, Randy Dunlap wrote: > On Mon, 7 Jun 2010 10:43:50 -0700 Greg KH wrote: > > > On Mon, Jun 07, 2010 at 12:57:12PM +0100, Ian Abbott wrote: > > > From: Ian Abbott <abbotti(a)mev.co.uk> > > > > > > The kernel/hotplug sysctl variable (/proc/sys/kernel/hotplug file) was > > > made conditional on CONFIG_NET by commit > > > f743ca5e10f4145e0b3e6d11b9b46171e16af7ce (applied in 2.6.18) to fix > > > problems with undefined references in 2.6.16 when CONFIG_HOTPLUG=y && > > > !CONFIG_NET, but this restriction is no longer needed. > > Ack, builds for me on x86_64 when CONFIG_NET is not enabled. > > > Why is this restriction no longer needed? What changed? > > > commit cd3772e6898c6386f21d2958346d6dd57d4204f5 > Author: Ming Lei <tom.leiming(a)gmail.com> > Date: Sun Nov 16 18:22:09 2008 +0800 > > kernel/ksysfs.c:fix dependence on CONFIG_NET > > Access to uevent_seqnum and uevent_helper does not need to > depend on CONFIG_NET, so remove it. > > Signed-off-by: Ming Lei <tom.leiming(a)gmail.com> > Cc: Kay Sievers <kay.sievers(a)vrfy.org> > Signed-off-by: Greg Kroah-Hartman <gregkh(a)suse.de> So something back in 2008 changed which requires a change now? I'm still confused, what use case calls for the original patch here being made? Who wants to modify this option with CONFIG_NET disabled on their machine? thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
|
Next
|
Last
Pages: 1 2 Prev: Dear Webmail/E-mail User Next: [PATCHv4 05/13] USB: gadget: f_fs: use usb_string_ids_n() |