TCP keepalive support for libpq
in [PgSql]
|
From: Fujii Masao on 15 Feb 2010 05:18 On Sat, Feb 13, 2010 at 2:13 AM, Euler Taveira de Oliveira <euler(a)timbira.com> wrote: > Marko Kreen escreveu: >> 3) Support all 3 parameters (keepidle, keepintvl, keepcnt) >> and ignore parameters not supported by OS. >> > +1. AFAIR, we already do that for the backend. +1 from me, too. Here is the patch which provides those three parameters as conninfo options. Should this patch be added into the first CommitFest for v9.1? Regards, -- Fujii Masao NIPPON TELEGRAPH AND TELEPHONE CORPORATION NTT Open Source Software Center
From: Euler Taveira de Oliveira on 15 Feb 2010 09:45 Fujii Masao escreveu: > Here is the patch which provides those three parameters as conninfo > options. Should this patch be added into the first CommitFest for v9.1? > Go ahead. -- Euler Taveira de Oliveira http://www.timbira.com/ -- Sent via pgsql-hackers mailing list (pgsql-hackers(a)postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
From: Magnus Hagander on 15 Feb 2010 09:52 2010/2/15 Euler Taveira de Oliveira <euler(a)timbira.com>: > Fujii Masao escreveu: >> Here is the patch which provides those three parameters as conninfo >> options. Should this patch be added into the first CommitFest for v9.1? >> > Go ahead. If we want to do this, I'd be inclined to say we sneak this into 9.0.. It's small enough ;) -- Magnus Hagander Me: http://www.hagander.net/ Work: http://www.redpill-linpro.com/ -- Sent via pgsql-hackers mailing list (pgsql-hackers(a)postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
From: Robert Haas on 15 Feb 2010 10:08 On Mon, Feb 15, 2010 at 9:52 AM, Magnus Hagander <magnus(a)hagander.net> wrote: > 2010/2/15 Euler Taveira de Oliveira <euler(a)timbira.com>: >> Fujii Masao escreveu: >>> Here is the patch which provides those three parameters as conninfo >>> options. Should this patch be added into the first CommitFest for v9.1? >>> >> Go ahead. > > If we want to do this, I'd be inclined to say we sneak this into 9.0.. > It's small enough ;) I think that's reasonable, provided that we don't change the default behavior. I think it's too late to change the default behavior of much of anything for 9.0, and libpq seems like a particularly delicate place to be changing things. I also think adding three new environment variables for this is likely overkill. I'd rip that part out. Just to be clear, I don't intend to work on this myself. But I am in favor of YOU working on it. :-) ....Robert -- Sent via pgsql-hackers mailing list (pgsql-hackers(a)postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
From: Euler Taveira de Oliveira on 15 Feb 2010 10:15
Magnus Hagander escreveu: > If we want to do this, I'd be inclined to say we sneak this into 9.0.. > It's small enough ;) > I'm afraid Robert will say a big NO. ;) I'm not against your idea; so if nobody objects go for it *now*. -- Euler Taveira de Oliveira http://www.timbira.com/ -- Sent via pgsql-hackers mailing list (pgsql-hackers(a)postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers |