Tools perf probe-finder.c: duplicated include
in [Kernel]
|
Prev: Question about e06e7c615877026544ad7f8b309d1a3706410383 -- [IPV4]: The scheduled removal of multipath cached routing support.
Next: [PATCH 0/4] io-controller: Use names rather than major:minor
From: Masami Hiramatsu on 25 Mar 2010 13:50 Hi Andrea, Andrea Gelmini wrote: > tools/perf/util/probe-finder.c: string.h is included more than once. Would you mean that <string.h> and "string.h" are duplicated? If so, NAK, sorry. Those are different, <string.h> is for /usr/include/string.h, and "string.h" is for tools/perf/util/string.h. Thank you, > > Signed-off-by: Andrea Gelmini <andrea.gelmini(a)gelma.net> > --- > tools/perf/util/probe-finder.c | 1 - > 1 files changed, 0 insertions(+), 1 deletions(-) > > diff --git a/tools/perf/util/probe-finder.c b/tools/perf/util/probe-finder.c > index 1e6c65e..682eb37 100644 > --- a/tools/perf/util/probe-finder.c > +++ b/tools/perf/util/probe-finder.c > @@ -32,7 +32,6 @@ > #include <stdarg.h> > #include <ctype.h> > > -#include "string.h" > #include "event.h" > #include "debug.h" > #include "util.h" -- Masami Hiramatsu e-mail: mhiramat(a)redhat.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: KOSAKI Motohiro on 26 Mar 2010 01:40 > Hi Andrea, > > Andrea Gelmini wrote: > > tools/perf/util/probe-finder.c: string.h is included more than once. > > Would you mean that <string.h> and "string.h" are duplicated? > If so, NAK, sorry. Those are different, <string.h> is for > /usr/include/string.h, and "string.h" is for tools/perf/util/string.h. > > Thank you, I think this discussion suggested "string.h" should be renameed more review friendly name. probably. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Masami Hiramatsu on 26 Mar 2010 11:50 KOSAKI Motohiro wrote: >> Hi Andrea, >> >> Andrea Gelmini wrote: >>> tools/perf/util/probe-finder.c: string.h is included more than once. >> >> Would you mean that <string.h> and "string.h" are duplicated? >> If so, NAK, sorry. Those are different, <string.h> is for >> /usr/include/string.h, and "string.h" is for tools/perf/util/string.h. >> >> Thank you, > > I think this discussion suggested "string.h" should be renameed more review > friendly name. probably. Hmm, we'd better review files under tools/utils/include too. :( (not sure why we have those files, because some files includes headers from original include directory, as like as "../../include/linux/blahblah.h") Thank you, -- Masami Hiramatsu e-mail: mhiramat(a)redhat.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Arnaldo Carvalho de Melo on 26 Mar 2010 14:30
Em Fri, Mar 26, 2010 at 11:44:15AM -0400, Masami Hiramatsu escreveu: > KOSAKI Motohiro wrote: > >> Hi Andrea, > >> > >> Andrea Gelmini wrote: > >>> tools/perf/util/probe-finder.c: string.h is included more than once. > >> > >> Would you mean that <string.h> and "string.h" are duplicated? > >> If so, NAK, sorry. Those are different, <string.h> is for > >> /usr/include/string.h, and "string.h" is for tools/perf/util/string.h. > >> > >> Thank you, > > > > I think this discussion suggested "string.h" should be renameed more review > > friendly name. probably. String should be renamed, yes, I'll do that. > Hmm, we'd better review files under tools/utils/include too. :( > (not sure why we have those files, because some files includes > headers from original include directory, as like as > "../../include/linux/blahblah.h") To share code with the kernel (rbtree.[ch], list.h). - Arnaldo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ |