Prev: Reporting bugs (was: Timing code blocks)
Next: This MIDI stuff, would someone be interested in reviewing my code?
From: Phil Thornley on 7 Mar 2010 06:43
On 7 Mar, 11:20, Simon Wright <si...(a)pushface.org> wrote:
> Phil Thornley <phil.jpthorn...(a)googlemail.com> writes:
> > The problem is that the value of the variables that provide the loop
> > bounds (in your code the variable Characters_To_Copy) can be changed
> > within the loop, so any reference to Characters_To_Copy within an
> > assertion in the loop means the *current* value, not the value that
> > defined the loop bound.
>
> Would it have helped if Peter had said, instead of
>
>       Characters_To_Copy : Line_Size_Type;
>    begin
>       Result.Text := Line_Type'(others => ' ');
>       if Line'Length > Max_Line_Length then
>          Characters_To_Copy := Max_Line_Length;
>       else
>          Characters_To_Copy := Line'Length;
>       end if;
>
> this:
>
>       Characters_To_Copy : constant Line_Size_Type
>         := Line_Size_Type'Min (Line'Length, Max_Line_Length);
>    begin
>       Result.Text := Line_Type'(others => ' ');
>
> And I'm sure one could eliminate the loop by proper slicing. Of course,
> that would reduce the SPARK learning experience ...

Well - he would have learned that it isn't valid SPARK :-)
(All initialization values must be static and slices aren't allowed
either)

Cheers,

Phil
From: Simon Wright on 7 Mar 2010 11:27
Phil Thornley <phil.jpthornley(a)googlemail.com> writes:

> Well - he would have learned that it isn't valid SPARK :-)
> (All initialization values must be static and slices aren't allowed
> either)

Hmpf. Much better Ada, though (IMO, of course).
First  |  Prev  | 
Pages: 1 2
Prev: Reporting bugs (was: Timing code blocks)
Next: This MIDI stuff, would someone be interested in reviewing my code?