USB: composite: allow optional removal of __init and __exit tags
in [Kernel]
|
Prev: [PATCH] macb: allow reception of large (>1518 bytes) frames
Next: sched: __wake_up_locked() exported
From: Greg KH on 7 Apr 2010 11:30 On Wed, Apr 07, 2010 at 03:41:28PM +0200, Michal Nazarewicz wrote: > The composite framework has been written using __init and __exit tags > to mark init and exit functions as such. This works with most of the > composite gadgets however some may need to call init/exit functions > during normal operations. One example is mass storage gadget which > needs to call exit functions. > > This patch allows gadgets to define USB_NO_INIT_SEGMENT or > USB_NO_EXIT_SEGMENT to remove the __init and __exit declarations > from composite framework. Ick ick ick. How about we just drop the __init and __exit tags completly and then we don't have to propagate this mess any further? How much memory do they really save anyway? I don't like this at all... thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Greg KH on 7 Apr 2010 20:40
On Wed, Apr 07, 2010 at 05:39:35PM +0200, Michał Nazarewicz wrote: > >On Wed, Apr 07, 2010 at 03:41:28PM +0200, Michal Nazarewicz wrote: > >>The composite framework has been written using __init and __exit tags > >>to mark init and exit functions as such. This works with most of the > >>composite gadgets however some may need to call init/exit functions > >>during normal operations. One example is mass storage gadget which > >>needs to call exit functions. > >> > >>This patch allows gadgets to define USB_NO_INIT_SEGMENT or > >>USB_NO_EXIT_SEGMENT to remove the __init and __exit declarations > >>from composite framework. > > On Wed, 07 Apr 2010 17:28:52 +0200, Greg KH <greg(a)kroah.com> wrote: > >How about we just drop the __init and __exit tags completly and then > >we don't have to propagate this mess any further? > > Personally, I don't care, ;) so if you think it's better to drop it all > together I can change it in a future patch. That would be great. thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ |