USB: gadget: mass storage: use proper device class in device desc
in [Kernel]
|
Prev: USB: gadget: mass storage: use proper device class in device desc
Next: USB: gadget: mass/file storage: set serial number
From: Michał Nazarewicz on 1 Jul 2010 06:20 On Thu, 01 Jul 2010 12:09:48 +0200, David Brownell <david-b(a)pacbell.net> wrote: > It works now though ... why change it, > and risk causing breakage?? OK. -- Best regards, _ _ | Humble Liege of Serenely Enlightened Majesty of o' \,=./ `o | Computer Science, Michał "mina86" Nazarewicz (o o) +----[mina86*mina86.com]---[mina86*jabber.org]----ooO--(_)--Ooo-- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Alan Stern on 1 Jul 2010 10:10 On Thu, 1 Jul 2010, Michal Nazarewicz wrote: > Hello Alan, > > Each time I see the device descriptor of the File Storage Gadget > I wonder if it shouldn't be set to the real value rather then leaving > it as per interface. It should not be changed. > Is there a reason to leave it as per interface? See Table 4.1 in the USB Mass Storage Bulk-Only Transport specification and Table 3.1 in the CBI Transport specification. > Will chenging it to > the real value change anything? You mean will it hurt anything? I don't know; I have never tried it. > I checked my pendrive and an IDE<->USB adapter they as well use a per > interface class but maybe it'll be better to use proper call any way? No. And it's not a proper call -- it's not even the proper descriptor valu. So NAK on this patch. Alan Stern -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Michał Nazarewicz on 1 Jul 2010 10:30
> On Thu, 1 Jul 2010, Michal Nazarewicz wrote: >> Each time I see the device descriptor of the File Storage Gadget >> I wonder if it shouldn't be set to the real value rather then leaving >> it as per interface. On Thu, 01 Jul 2010 16:09:39 +0200, Alan Stern <stern(a)rowland.harvard.edu> wrote: > It should not be changed. >> Is there a reason to leave it as per interface? > See Table 4.1 in the USB Mass Storage Bulk-Only Transport > specification and Table 3.1 in the CBI Transport specification. Ha! Thanks for clarification. Will have to look more careful through the specs next time. -- Best regards, _ _ | Humble Liege of Serenely Enlightened Majesty of o' \,=./ `o | Computer Science, Michał "mina86" Nazarewicz (o o) +----[mina86*mina86.com]---[mina86*jabber.org]----ooO--(_)--Ooo-- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ |