USB-serial dummy cable driver
in [Kernel]
|
From: Greg KH on 2 Aug 2010 19:00 On Mon, Aug 02, 2010 at 08:00:07AM +0200, Marek Vasut wrote: > This driver is used to implement USB-serial like behaviour over dummy > USB cables. These are used in the following devices: > Funsoft Serial USB driver > Genesys Logic GL620USB USB Laplink cable > HP4x (48/49) Serial cable > Motorola phones > Siemens USB-MPI Serial USB driver > ViVOpay USB Serial Driver > ZIO Motherboard USB driver I like the idea, but not the name :) Ideally, all of these would be able to be handled by the usb-serial generic driver directly. But really, having these multiple drivers is a good thing, they properly convey to the user what the device is, and it gives these developers and companies a sense of ownership over the code, and that matters at times. So you lost the names of the devices with this patch, which isn't good. It's my end-goal to move the usb-serial layer to be more like libata, where it is dirt-simple to make a new disk driver, only a few fields to fill in, what you want to override. So, any work toward simplification of the generic layer would be appreciated to make these individual drivers even smaller in the end. So don't delete them, but try to consolidate the code, or just make it so that it can be deleted, and you only need a simple module init/exit function that registeres a single structure, like libata. Sound reasonable? thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Marek Vasut on 3 Aug 2010 12:20 Dne �t 3. srpna 2010 00:47:18 Greg KH napsal(a): > On Mon, Aug 02, 2010 at 08:00:07AM +0200, Marek Vasut wrote: > > This driver is used to implement USB-serial like behaviour over dummy > > > > USB cables. These are used in the following devices: > > Funsoft Serial USB driver > > Genesys Logic GL620USB USB Laplink cable > > HP4x (48/49) Serial cable > > Motorola phones > > Siemens USB-MPI Serial USB driver > > ViVOpay USB Serial Driver > > ZIO Motherboard USB driver > > I like the idea, but not the name :) Please don't expect miracles from me after 26 hours without sleep ;-) > > Ideally, all of these would be able to be handled by the usb-serial > generic driver directly. I just noticed that one. Stupid me. > > But really, having these multiple drivers is a good thing, they properly > convey to the user what the device is, and it gives these developers and > companies a sense of ownership over the code, and that matters at times. > > So you lost the names of the devices with this patch, which isn't good. Sheesh ... that's true, but having pile of copies of the same code is not good either. Can't we then just deprecate all these drivers and set correct udev rules? > > It's my end-goal to move the usb-serial layer to be more like libata, > where it is dirt-simple to make a new disk driver, only a few fields to > fill in, what you want to override. So, any work toward simplification > of the generic layer would be appreciated to make these individual > drivers even smaller in the end. > > So don't delete them, but try to consolidate the code, or just make it > so that it can be deleted, and you only need a simple module init/exit > function that registeres a single structure, like libata. > > Sound reasonable? Sounds ok, I'd like to help you but I'm dead busy with a pile of ARM machines here. This hack was really just a side-job. I'll try looking into it if I wont get insane ;-) Cheers > > thanks, > > greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Greg KH on 3 Aug 2010 13:10 On Tue, Aug 03, 2010 at 06:14:15PM +0200, Marek Vasut wrote: > Dne �t 3. srpna 2010 00:47:18 Greg KH napsal(a): > > On Mon, Aug 02, 2010 at 08:00:07AM +0200, Marek Vasut wrote: > > > This driver is used to implement USB-serial like behaviour over dummy > > > > > > USB cables. These are used in the following devices: > > > Funsoft Serial USB driver > > > Genesys Logic GL620USB USB Laplink cable > > > HP4x (48/49) Serial cable > > > Motorola phones > > > Siemens USB-MPI Serial USB driver > > > ViVOpay USB Serial Driver > > > ZIO Motherboard USB driver > > > > I like the idea, but not the name :) > > Please don't expect miracles from me after 26 hours without sleep ;-) > > > > Ideally, all of these would be able to be handled by the usb-serial > > generic driver directly. > > I just noticed that one. Stupid me. > > > > But really, having these multiple drivers is a good thing, they properly > > convey to the user what the device is, and it gives these developers and > > companies a sense of ownership over the code, and that matters at times. > > > > So you lost the names of the devices with this patch, which isn't good. > > Sheesh ... that's true, but having pile of copies of the same code is not good > either. I agree, that's why I said it should be reduced. > Can't we then just deprecate all these drivers and set correct udev > rules? udev can not change the name of the device in sysfs, or the name in the kernel of the device. thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Marek Vasut on 3 Aug 2010 13:40 Dne �t 3. srpna 2010 18:38:26 Greg KH napsal(a): > On Tue, Aug 03, 2010 at 06:14:15PM +0200, Marek Vasut wrote: > > Dne �t 3. srpna 2010 00:47:18 Greg KH napsal(a): > > > On Mon, Aug 02, 2010 at 08:00:07AM +0200, Marek Vasut wrote: > > > > This driver is used to implement USB-serial like behaviour over dummy > > > > > > > > USB cables. These are used in the following devices: > > > > Funsoft Serial USB driver > > > > Genesys Logic GL620USB USB Laplink cable > > > > HP4x (48/49) Serial cable > > > > Motorola phones > > > > Siemens USB-MPI Serial USB driver > > > > ViVOpay USB Serial Driver > > > > ZIO Motherboard USB driver > > > > > > I like the idea, but not the name :) > > > > Please don't expect miracles from me after 26 hours without sleep ;-) > > > > > Ideally, all of these would be able to be handled by the usb-serial > > > generic driver directly. > > > > I just noticed that one. Stupid me. > > > > > But really, having these multiple drivers is a good thing, they > > > properly convey to the user what the device is, and it gives these > > > developers and companies a sense of ownership over the code, and that > > > matters at times. > > > > > > So you lost the names of the devices with this patch, which isn't good. > > > > Sheesh ... that's true, but having pile of copies of the same code is not > > good either. > > I agree, that's why I said it should be reduced. > > > Can't we then just deprecate all these drivers and set correct udev > > rules? > > udev can not change the name of the device in sysfs, or the name in the > kernel of the device. That's right, but it can bind the generic driver with the hardware. And who would care about the driver name, really ? The interface just appears and that's what matters (to me and probably to users) ... > > thanks, > > greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Greg KH on 3 Aug 2010 14:00 On Tue, Aug 03, 2010 at 07:36:39PM +0200, Marek Vasut wrote: > Dne �t 3. srpna 2010 18:38:26 Greg KH napsal(a): > > On Tue, Aug 03, 2010 at 06:14:15PM +0200, Marek Vasut wrote: > > > Dne �t 3. srpna 2010 00:47:18 Greg KH napsal(a): > > > > On Mon, Aug 02, 2010 at 08:00:07AM +0200, Marek Vasut wrote: > > > > > This driver is used to implement USB-serial like behaviour over dummy > > > > > > > > > > USB cables. These are used in the following devices: > > > > > Funsoft Serial USB driver > > > > > Genesys Logic GL620USB USB Laplink cable > > > > > HP4x (48/49) Serial cable > > > > > Motorola phones > > > > > Siemens USB-MPI Serial USB driver > > > > > ViVOpay USB Serial Driver > > > > > ZIO Motherboard USB driver > > > > > > > > I like the idea, but not the name :) > > > > > > Please don't expect miracles from me after 26 hours without sleep ;-) > > > > > > > Ideally, all of these would be able to be handled by the usb-serial > > > > generic driver directly. > > > > > > I just noticed that one. Stupid me. > > > > > > > But really, having these multiple drivers is a good thing, they > > > > properly convey to the user what the device is, and it gives these > > > > developers and companies a sense of ownership over the code, and that > > > > matters at times. > > > > > > > > So you lost the names of the devices with this patch, which isn't good. > > > > > > Sheesh ... that's true, but having pile of copies of the same code is not > > > good either. > > > > I agree, that's why I said it should be reduced. > > > > > Can't we then just deprecate all these drivers and set correct udev > > > rules? > > > > udev can not change the name of the device in sysfs, or the name in the > > kernel of the device. > > That's right, but it can bind the generic driver with the hardware. And who > would care about the driver name, really ? The interface just appears and that's > what matters (to me and probably to users) ... There are persistant device links in /dev/serial/ that might care about the driver name. We don't want to break them, right? thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
|
Next
|
Last
Pages: 1 2 Prev: vhost-net patchset for 2.6.36 Next: drivers/net/wan/farsync.c: Use standard pr_<level> |