Prev: rmap: make anon_vma_prepare link in all the anon_vmas of a mergeable VMA
Next: [PATCH] race condition between __purge_vmap_area_lazy() and free_unmap_vmap_area_noflush()
From: Greg KH on 8 Apr 2010 02:20
On Thu, Apr 08, 2010 at 09:10:00AM +0300, Heikki Krogerus wrote:
> Hi,
>
> If this is going into kernel then..
>
> On Wed, Apr 07, 2010 at 03:41:34PM +0200, ext Michal Nazarewicz wrote:
>
> ...
>
> > + if ((c = open ("/proc/bus/usb/devices", O_RDONLY)) < 0) {
> > + fputs ("usbfs files are missing\n", stderr);
> > + return -1;
> > + }
>
> Is this needed?
>
> > +
> > + /* collect and list the test devices */
> > + if (ftw ("/proc/bus/usb", find_testdev, 3) != 0) {
>
> How about "/dev/bus/usb" instead? Some distributions do not enable
> sysfs in their default kernels anymore.

You mean 'usbfs' not 'sysfs', right?

And yes, this probably should be fixed, patches are always welcome :)

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: Greg KH on 14 Apr 2010 13:00
On Wed, Apr 14, 2010 at 02:30:52AM -0700, David Brownell wrote:
> On Wednesday 07 April 2010, Greg KH wrote:
> > You should put a:
> > ????????From: David Brownell <dbrownell(a)users.sourceforge.net>
> > as the first line of the body of this patch, so it properly shows up as
> > David's code.
> >
> > I also would like to get an ack from David that he doesn't mind his code
> > moving into the kernel here (personally I think it's a good thing to be
> > here.)
> >
> > thanks,
>
> ISTR sending an ack .... but, not with a "From:" like that. I did author the
> code, but the *patch* is not from me.

The "From:" shows authorship, which is the correct statement here, we
want to preserve it. I know you didn't generate the patch, but that's
ok :)

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: Greg KH on 14 Apr 2010 13:00
On Wed, Apr 14, 2010 at 02:50:41PM +0200, Micha?? Nazarewicz wrote:
> However, if Greg thinks it might be a good idea to put some testing code
> into the tree, then it's fine by me. This may even lead to more testing
> tools be submitted and maybe after some time an unified testing framework
> may emerge.
>
> Bottom line is, if community (represented by the maintainer ;) ) wants the
> patches in the kernel, then let them have it!

Yes, I would like the code in the kernel.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
 | 
Pages: 1
Prev: rmap: make anon_vma_prepare link in all the anon_vmas of a mergeable VMA
Next: [PATCH] race condition between __purge_vmap_area_lazy() and free_unmap_vmap_area_noflush()