Prev: [PATCH 22/37] x86: Remove not used early_res code
Next: pci: fix compilation when CONFIG_PCI_MSI=n
From: Linus Torvalds on 16 Jun 2010 02:20
On Tuesday, June 15, 2010, Yinghai Lu <yinghai(a)kernel.org> wrote:
>
> �46 files changed, 1476 insertions(+), 1282 deletions(-)

So what was the advantage again? It's adding more lines than it
removes. Wasn't the point to simplify things, not make them bigger?

Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: Yinghai Lu on 16 Jun 2010 11:50
On 06/16/2010 01:41 AM, Benjamin Herrenschmidt wrote:
> On Tue, 2010-06-15 at 23:10 -0700, Linus Torvalds wrote:
>> On Tuesday, June 15, 2010, Yinghai Lu <yinghai(a)kernel.org> wrote:
>>>
>>> 46 files changed, 1476 insertions(+), 1282 deletions(-)
>>
>> So what was the advantage again? It's adding more lines than it
>> removes. Wasn't the point to simplify things, not make them bigger?
>
> I -think- the point is that once that's done, you can remove a whole lot
> of gunk that was added such as the kernel/range.c caca, etc...
> (basically, x86 gunk gratuituously made generic and that should really
> just die instead).

right.

this patch include seperate bootmem.c into bootmem.c and nobootmem.c to reduce
MACRO according Ingo and others.
mm/bootmem.c | 165 +----------
mm/nobootmem.c | 415 +++++++++++++++++++++++++++

later will
1. remove x86 own copy for find_from_low_to_high after more testing with high to low. that is about 200 lines code.
2. replace range.c with lmb. but need to expand lmb little bit
like add can_resize and can_merge to be attribute of lmb_type.

Thanks

Yinghai Lu
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: Bjorn Helgaas on 29 Jun 2010 14:10
On Tuesday, June 22, 2010 11:26:29 am Yinghai Lu wrote:
> New lmb could be used to replace early_res in x86.

Since you're fiddling in e820 anyway, can you fix places like
e820_print_map() so they use the %pR format? I think it'd be
cleaner if e820_print_type() just returned a string pointer
rather than calling printk directly. Then we'd only need a
single printk per region and wouldn't need the KERN_CONT junk.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
 | 
Pages: 1
Prev: [PATCH 22/37] x86: Remove not used early_res code
Next: pci: fix compilation when CONFIG_PCI_MSI=n