From: Dave Page on
On Fri, Mar 5, 2010 at 4:02 AM, Craig Ringer
<craig(a)postnewspapers.com.au> wrote:
> Kevin Flanagan wrote:
>
>> the compiler
>> complained about various missing include files, starting with
>> ‘libintl.h’. Having read the post at
>> http://archives.postgresql.org/pgsql-general/2009-03/msg00332.php I
>> created an empty libint.h in an include dir
>
> NFI why Pg for win32 doesn't bundle a copy of the libintl it was built
> against. I should poke the EDB guys about it, actually.

We do include the library. We don't include the headers or source for
third party code though - that would be considered part of the build
environment, just the same as the Windows SDK.



--
Dave Page
EnterpriseDB UK: http://www.enterprisedb.com
PG East Conference: http://www.enterprisedb.com/community/nav-pg-east-2010.do

--
Sent via pgsql-hackers mailing list (pgsql-hackers(a)postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

From: Dave Page on
On Fri, Mar 5, 2010 at 9:05 AM, Craig Ringer
<craig(a)postnewspapers.com.au> wrote:

> How do _you_ go about building server extensions for Pg? Where do you
> get the headers for gettext etc?

Same place I get the binaries - gnuwin32 mostly.

> I'm increasingly thinking the win32 package _should_ be split into
> server binary and separate headers+pdb+sources packages, with the sdk
> package including gettext headers and sources too. It'd be a LOT easier
> to develop with Pg on win32 this way.

How does breaking it up into multiple packages make it easier?


--
Dave Page
EnterpriseDB UK: http://www.enterprisedb.com
PG East Conference: http://www.enterprisedb.com/community/nav-pg-east-2010.do

--
Sent via pgsql-hackers mailing list (pgsql-hackers(a)postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

From: Dave Page on
On Fri, Mar 5, 2010 at 9:31 AM, Craig Ringer
<craig(a)postnewspapers.com.au> wrote:

> Why _not_ distribute gettext headers, though? Sources I can understand
> for size reasons, but the headers are small and fuss free, and you need
> the _right_ _versions_ to build against the Pg backend.

No reason, other than I didn't realise they were needed to build extension.

--
Dave Page
EnterpriseDB UK: http://www.enterprisedb.com
PG East Conference: http://www.enterprisedb.com/community/nav-pg-east-2010.do

--
Sent via pgsql-hackers mailing list (pgsql-hackers(a)postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

From: "Kevin Flanagan" on
Ok, re "building with the win32 configuration" ... that sounds like just the thing I should know about. All I've done is downloaded and installed the 1-click installer for Windows from http://www.enterprisedb.com/products/pgdownload.do#windows ... so while I'm sure it knows it's running on Win32, is there some other configuration change I should make for dev purposes to indicate that it's "the win32 configuration"? Or does "building with the win32 configuration" refer to those who are building the server from source, or something?

Thanks

Kevin

-----Original Message-----
From: Craig Ringer [mailto:craig(a)postnewspapers.com.au]
Sent: 05 March 2010 04:02
To: Kevin Flanagan
Cc: pgsql-hackers(a)postgresql.org
Subject: Re: [HACKERS] Visual Studio 2005, C-language function - avoiding hacks?

Kevin Flanagan wrote:

> the compiler
> complained about various missing include files, starting with
> ‘libintl.h’. Having read the post at
> http://archives.postgresql.org/pgsql-general/2009-03/msg00332.php I
> created an empty libint.h in an include dir

NFI why Pg for win32 doesn't bundle a copy of the libintl it was built
against. I should poke the EDB guys about it, actually.

> along with a bunch of other
> empty dummy files that were expected: netdb.h, pwd.h, netinet/in.h and
> arpa/inet.h.

Those I wouldn't expect to be included if you're building for win32.

Are you sure you're building with the win32 configuration?

> The code then compiles ok, but gives ‘inconsistent dll linkage’ on the
> line with PG_FUNCTION_INFO_V1 and the one with PG_MODULE_MAGIC.

This would suggest that the macros that insert appropriate
__declspec(dllimport) and __declspec(dllexport) attributes aren't being
triggered - so again, it makes me wonder if Pg knows it's building for
win32.

--
Craig Ringer


--
Sent via pgsql-hackers mailing list (pgsql-hackers(a)postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

From: Dave Page on
On Fri, Mar 5, 2010 at 9:50 AM, Craig Ringer
<craig(a)postnewspapers.com.au> wrote:
> Dave Page wrote:
>> On Fri, Mar 5, 2010 at 9:31 AM, Craig Ringer
>> <craig(a)postnewspapers.com.au> wrote:
>>
>>> Why _not_ distribute gettext headers, though? Sources I can understand
>>> for size reasons, but the headers are small and fuss free, and you need
>>> the _right_ _versions_ to build against the Pg backend.
>>
>> No reason, other than I didn't realise they were needed to build extension.
>>
>
> Ah, fair enough. I read:
>
>> We do include the library. We don't include the headers or source for
>> third party code though - that would be considered part of the build
>> environment, just the same as the Windows SDK.
>
> as "we don't want to distribute third-party headers even if required by
> Pg's own headers" and thus thought you *did* know but by policy didn't
> want to distribute them.

I didn't know in this case, but was making a general statement about
how I felt the policy should be.

Plus I was feeling a little grumpy in my pre-coffee state. Sorry :-p

--
Dave Page
EnterpriseDB UK: http://www.enterprisedb.com
PG East Conference: http://www.enterprisedb.com/community/nav-pg-east-2010.do

--
Sent via pgsql-hackers mailing list (pgsql-hackers(a)postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers