What's wrong in this function? Does not work for me.
in [General]
|
From: Carlos Sura on 2 Jul 2010 18:05 Hello, this function does not work for me... And I really don't know what am I doing wrong... Any help?? This function is in a class, and I call it in a form, to create a new user.. $objEmploye=new Employe; if ( $objEmploye->insert(array($name,$lastname,$salary,$dui,$afp,$isss,$nit)) == true){ echo 'Saved'; }else{ echo 'Error, try again'; } }else{ function insert($field){ if($this->con->connect()==true){ return mysql_query("INSERT INTO employes (name,lastname, salary, id, afp, isss, nit) VALUES ('".$field[0]."', '".$field[1]."','".$field[2]."','".$field[3]."','".$field[4]."','".$field[5]."','".$field[6]."')"); } } Thanks. _________________________________________________________________ http://clk.atdmt.com/UKM/go/197222280/direct/01/ Do you have a story that started on Hotmail? Tell us now
From: Ashley Sheridan on 2 Jul 2010 19:08 On Fri, 2010-07-02 at 22:05 +0000, Carlos Sura wrote: > > Hello, this function does not work for me... And I really don't know what am I doing wrong... Any help?? > > This function is in a class, and I call it in a form, to create a new user.. > > > > $objEmploye=new Employe; > if ( $objEmploye->insert(array($name,$lastname,$salary,$dui,$afp,$isss,$nit)) == true){ > echo 'Saved'; > }else{ > echo 'Error, try again'; > } > }else{ > > > function insert($field){ > if($this->con->connect()==true){ > return mysql_query("INSERT INTO employes (name,lastname, salary, id, afp, isss, nit) VALUES ('".$field[0]."', '".$field[1]."','".$field[2]."','".$field[3]."','".$field[4]."','".$field[5]."','".$field[6]."')"); > } > } > > > > > Thanks. > > _________________________________________________________________ > http://clk.atdmt.com/UKM/go/197222280/direct/01/ > Do you have a story that started on Hotmail? Tell us now I can't see anything wrong with that code excerpt. Are you getting a specific error, and if so, what is the code on and around the line number indicated in that error? Thanks, Ash http://www.ashleysheridan.co.uk
From: Carlos Sura on 2 Jul 2010 19:19 Hello Ash, No, I don't get an error message, the thing is, my post form, isn't working... I can't post those fields in database when I fill them up in the form... But, I really don't know why... Do you want my form code? all the entire class.php code?? Thank you for helping me. Carlos Sura. Subject: Re: [PHP] What's wrong in this function? Does not work for me. From: ash(a)ashleysheridan.co.uk To: carlos_sura(a)hotmail.com CC: php-general(a)lists.php.net Date: Sat, 3 Jul 2010 00:08:05 +0100 On Fri, 2010-07-02 at 22:05 +0000, Carlos Sura wrote: Hello, this function does not work for me... And I really don't know what am I doing wrong... Any help?? This function is in a class, and I call it in a form, to create a new user.. $objEmploye=new Employe; if ( $objEmploye->insert(array($name,$lastname,$salary,$dui,$afp,$isss,$nit)) == true){ echo 'Saved'; }else{ echo 'Error, try again'; } }else{ function insert($field){ if($this->con->connect()==true){ return mysql_query("INSERT INTO employes (name,lastname, salary, id, afp, isss, nit) VALUES ('".$field[0]."', '".$field[1]."','".$field[2]."','".$field[3]."','".$field[4]."','".$field[5]."','".$field[6]."')"); } } Thanks. _________________________________________________________________ http://clk.atdmt.com/UKM/go/197222280/direct/01/ Do you have a story that started on Hotmail? Tell us now I can't see anything wrong with that code excerpt. Are you getting a specific error, and if so, what is the code on and around the line number indicated in that error? Thanks, Ash http://www.ashleysheridan.co.uk _________________________________________________________________ http://clk.atdmt.com/UKM/go/197222280/direct/01/ We want to hear all your funny, exciting and crazy Hotmail stories. Tell us now
From: Ashley Sheridan on 2 Jul 2010 19:23 On Fri, 2010-07-02 at 23:19 +0000, Carlos Sura wrote: > Hello Ash, > > No, I don't get an error message, the thing is, my post form, isn't working... I can't post those fields in database when I fill them up in the form... But, I really don't know why... Do you want my form code? all the entire class.php code?? > > Thank you for helping me. > > Carlos Sura. > > > > > > > Subject: Re: [PHP] What's wrong in this function? Does not work for me. > From: ash(a)ashleysheridan.co.uk > To: carlos_sura(a)hotmail.com > CC: php-general(a)lists.php.net > Date: Sat, 3 Jul 2010 00:08:05 +0100 > > > > > > > > > > > On Fri, 2010-07-02 at 22:05 +0000, Carlos Sura wrote: > > > Hello, this function does not work for me... And I really don't know what am I doing wrong... Any help?? > > This function is in a class, and I call it in a form, to create a new user.. > > > > $objEmploye=new Employe; > if ( $objEmploye->insert(array($name,$lastname,$salary,$dui,$afp,$isss,$nit)) == true){ > echo 'Saved'; > }else{ > echo 'Error, try again'; > } > }else{ > > > function insert($field){ > if($this->con->connect()==true){ > return mysql_query("INSERT INTO employes (name,lastname, salary, id, afp, isss, nit) VALUES ('".$field[0]."', '".$field[1]."','".$field[2]."','".$field[3]."','".$field[4]."','".$field[5]."','".$field[6]."')"); > } > } > > > > > Thanks. > > _________________________________________________________________ > http://clk.atdmt.com/UKM/go/197222280/direct/01/ > Do you have a story that started on Hotmail? Tell us now > > > > > I can't see anything wrong with that code excerpt. Are you getting a specific error, and if so, what is the code on and around the line number indicated in that error? > > > > > > > Thanks, > > Ash > > http://www.ashleysheridan.co.uk > > > > > > > > > _________________________________________________________________ > http://clk.atdmt.com/UKM/go/197222280/direct/01/ > We want to hear all your funny, exciting and crazy Hotmail stories. Tell us now Break the code down into very simple parts with echo statements. First, I'd echo out the $_POST or $_GET data that you're using to see if the values you think are being sent are being sent. Then, move onto the next part of code, stepping through with echo statements to output variable values to ensure that your data is following the right path. This is one of the easiest ways to find a problem I've found, short of using an IDE to step through the code. Also, you could put the code up on something like pastebin and post a link to it, which will let people see what the code looks like and hopefully figure out where the problem is. Thanks, Ash http://www.ashleysheridan.co.uk
From: Alexandre Simon on 3 Jul 2010 03:01
Hello, multiple things: - escape your values: 1. if some of the user input contains '\'' for instance, your query is not well formed 2. if some evil user want to do anything with your DB, he can do it => See mysql_escape_string or PDO prepared statements - Use "else" part of the if statement everywhere you can to see where the error is. Maybe you can not connect to DB for instance... Hope you will fix your code.. Le vendredi 02 juillet 2010 à 22:05 +0000, Carlos Sura a écrit : > > Hello, this function does not work for me... And I really don't know what am I doing wrong... Any help?? > > This function is in a class, and I call it in a form, to create a new user.. > > > > $objEmploye=new Employe; > if ( $objEmploye->insert(array($name,$lastname,$salary,$dui,$afp,$isss,$nit)) == true){ > echo 'Saved'; > }else{ > echo 'Error, try again'; > } > }else{ > > > function insert($field){ > if($this->con->connect()==true){ > return mysql_query("INSERT INTO employes (name,lastname, salary, id, afp, isss, nit) VALUES ('".$field[0]."', '".$field[1]."','".$field[2]."','".$field[3]."','".$field[4]."','".$field[5]."','".$field[6]."')"); > } > } > > > > > Thanks. > > _________________________________________________________________ > http://clk.atdmt.com/UKM/go/197222280/direct/01/ > Do you have a story that started on Hotmail? Tell us now |