addjust discard request to be aligned with hwsect size to support SSDs with larger sector size
in [Kernel]
|
Prev: pcmciamtd: fix printk format warnings
Next: [patch 3/7] softirq: avoid softirq_work_list for SCHED_SOFTIRQ when sent remotely
From: Martin K. Petersen on 17 May 2010 15:00 >>>>> "Jiaying" == Jiaying Zhang <jiayingz(a)google.com> writes: Jiaying, Jiaying> The currect blkdev_issue_discard() function assumes 512 sector Jiaying> size. All of the block layer works on 512-byte sector units. We don't generally convert to logical blocks until we're in the disk driver. Jiaying> We have seen some problem when using discard on a SSD that has Jiaying> larger sector size. The following patch adjusts the starting Jiaying> address and size of a discard request to be aligned with hwsect Jiaying> size. Jiaying> + int hwsect_shift = Jiaying> blksize_bits(bdev_logical_block_size(bdev)) - 9; Let's stop using the term hardware sector size. It's an anachronism. I guess I could understand if you aligned to the physical block size. But the logical doesn't make much sense to me. What is your logical block size? Right now we only handle 512 bytes and 4KB in the discard path. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ |