Prev: [V2 PATCH 02/10] i2c/of: Allow device node to be passed via i2c_board_info
Next: [PATCH] staging: winbond: mlmetxrx_f.h Coding style fixes.
From: Anton Vorontsov on 18 Mar 2010 11:50
Hi Grant,

On Thu, Mar 18, 2010 at 09:22:50AM -0600, Grant Likely wrote:
> Both dev_archdata.of_node and of_device.node are duplications of the
> device.of_node value. This patch removes them.

Yeah, they're plain duplications since you introduced dev.of_node.
I wonder what was the problem with using dev.archdata.of_node?
Why dev.of_node is better?

Also, by using dev.of_node directly you have to introduce ugly
#ifdefs in the non-OF code (as in i2c patch), which you don't
need with transparent archdata and accessors, which you've just
removed:

> -static inline void dev_archdata_set_node(struct dev_archdata *ad,
> - struct device_node *np)
> -{
> - ad->of_node = np;
> -}
> -
> -static inline struct device_node *
> -dev_archdata_get_node(const struct dev_archdata *ad)
> -{
> - return ad->of_node;
> -}

Thanks,

--
Anton Vorontsov
email: cbouatmailru(a)gmail.com
irc://irc.freenode.net/bd2
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
 | 
Pages: 1
Prev: [V2 PATCH 02/10] i2c/of: Allow device node to be passed via i2c_board_info
Next: [PATCH] staging: winbond: mlmetxrx_f.h Coding style fixes.