arm: msm: Add gpiolib support for MSM7200A-family chips.
in [Kernel]
|
Prev: MFD: AB8500 mask off irrelevant bits from the SPI message
Next: patch tty-remove-hayes-esp-ioctls.patch added to gregkh-2.6 tree
From: Daniel Walker on 17 Jun 2010 16:10 On Tue, 2010-06-15 at 19:43 -0700, Gregory Bean wrote: > Add support for uniprocessor MSM chips whose TLMM/GPIO design > is the same as the MSM7200A. > This includes, but is not necessarily limited to, the: > MSM7200A, MSM7x25, MSM7x27, MSM7x30, QSD8x50, QSD8x50A > > Signed-off-by: Gregory Bean <gbean(a)codeaurora.org> > --- > arch/arm/mach-msm/Kconfig | 7 ++ > arch/arm/mach-msm/Makefile | 2 +- > arch/arm/mach-msm/msm7200a-gpio.c | 187 +++++++++++++++++++++++++++++++++++++ > arch/arm/mach-msm/msm7200a-gpio.h | 62 ++++++++++++ > 4 files changed, 257 insertions(+), 1 deletions(-) > create mode 100644 arch/arm/mach-msm/msm7200a-gpio.c > create mode 100644 arch/arm/mach-msm/msm7200a-gpio.h > > diff --git a/arch/arm/mach-msm/Kconfig b/arch/arm/mach-msm/Kconfig > index 47264a7..d919b90 100644 > --- a/arch/arm/mach-msm/Kconfig > +++ b/arch/arm/mach-msm/Kconfig > @@ -106,4 +106,11 @@ config MSM_SMD_PKG3 > config MSM_SMD > bool > > +config MSM7200A_GPIO > + tristate "Qualcomm MSM7200A SoC GPIO support" > + depends on GPIOLIB > + help > + Say yes here to support GPIO functionality on Qualcomm's > + MSM chipsets which descend from the MSM7200a: > + MSM7x01(a), MSM7x25, MSM7x27, MSM7x30, QSD8x50(a). Can't we drop this? It's always going to be on right ? Daniel -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Greg Bean on 17 Jun 2010 16:10 >> +config MSM7200A_GPIO >> + tristate "Qualcomm MSM7200A SoC GPIO support" >> + depends on GPIOLIB >> + help >> + Say yes here to support GPIO functionality on Qualcomm's >> + MSM chipsets which descend from the MSM7200a: >> + MSM7x01(a), MSM7x25, MSM7x27, MSM7x30, QSD8x50(a). > > Can't we drop this? It's always going to be on right ? Not on all targets. There will be other drivers for chips from other lines. However, I would think that it could be entirely reasonable to lose the Kconfig and just hard-wire it in based on ARCH, if you like. Is that preferred? -- Employee of Qualcomm Innovation Center, Inc. Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Daniel Walker on 17 Jun 2010 16:20
On Thu, 2010-06-17 at 13:04 -0700, Greg Bean wrote: > >> +config MSM7200A_GPIO > >> + tristate "Qualcomm MSM7200A SoC GPIO support" > >> + depends on GPIOLIB > >> + help > >> + Say yes here to support GPIO functionality on Qualcomm's > >> + MSM chipsets which descend from the MSM7200a: > >> + MSM7x01(a), MSM7x25, MSM7x27, MSM7x30, QSD8x50(a). > > > > Can't we drop this? It's always going to be on right ? > > Not on all targets. There will be other drivers for chips from other > lines. However, I would think that it could be entirely reasonable to > lose the Kconfig and just hard-wire it in based on ARCH, if you like. > Is that preferred? Yeah, it's better not to have Kconfig options like this since it's easier for the user if we just encode this into options we know they have to select already. So for example they pick 8x50 via Kconfig, so we select for them the right stuff for 8x50 .. Otherwise we have to assume they know what to select which may not be the case, plus it could be a pain to go selecting all the related Kconfig options for low level stuff. If you respin this please re-send it privately just to me. Daniel -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ |