ath: fix macros coding style issue in regd.c
in [Kernel]
|
Prev: [PATCH 04/14] x86 acpi/irq: Fix acpi_sci_ioapic_setup so it has both bus_irq and gsi
Next: perf tools: Move the prototypes in util/string.h to util.h
From: Joe Perches on 29 Mar 2010 19:40 On Tue, 2010-03-30 at 00:12 +0100, Luis de Bethencourt wrote: > This is a patch to the ath/regd.c file that fixes up three warnings > about macros found by the checkpatch.pl tool, these said that > complex values should be enclosed in parenthesis. Hi Luis. Checkpatch isn't always correct. Please make sure to compile test your changes before submitting them. These macros are used as initializers and can not be surrounded by parentheses. .reg_rules = { ATH9K_2GHZ_ALL, cheers, Joe -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Luis de Bethencourt on 29 Mar 2010 19:40
On Tue, Mar 30, 2010 at 12:33 AM, Joe Perches <joe(a)perches.com> wrote: > On Tue, 2010-03-30 at 00:12 +0100, Luis de Bethencourt wrote: >> This is a patch to the ath/regd.c file that fixes up three warnings >> about macros found by the checkpatch.pl tool, these said that >> complex values should be enclosed in parenthesis. > > Hi Luis. > > Checkpatch isn't always correct. > > Please make sure to compile test your changes > before submitting them. > > These macros are used as initializers and > can not be surrounded by parentheses. > > � � � �.reg_rules = { > � � � � � � � �ATH9K_2GHZ_ALL, > > cheers, Joe > > Hi Joe, Sorry about this. I compiled test the changes but make didn't complain. My bad, will try to avoid this better in the future. Luis -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ |