atl1c: Add AR8151 v2 support and change L0s/L1 routine
in [Kernel]
|
Prev: fix packet loss and massive ping spikes with PPP multi-link
Next: skb: make skb_recycle_check() return a bool value
From: David Miller on 29 May 2010 03:10 From: <jie.yang(a)atheros.com> Date: Fri, 28 May 2010 15:40:38 +0800 > From: Jie.Yang(a)atheros.com > > Add AR8151 v2.0 Gigabit 1000 support > Change jumbo frame size to 6K > Update L0s/L1 rountine > Update atl1c_suspend routine. > > Signed-off-by: Jie.Yang(a)atheros.com Your commit log message is way too terse. You should describe in detail what your changes are. Saying "Update L0s/L1 routine" doesn't tell us exactly what change you are making. And more importantly, it does not tell us why you are making this change. This also applied to "update atl1c_suspend routine" You have to list exactly change you are making, and why. You should be able to write a full paragraph explaining what each change is, and the reason for that change. This means 4 to 5 full english sentences, which means more than 3 or 4 words in each sentence. Do not try to put as minimal amount of information into your commit messages as possible, instead strive to put too much information. Be long winded, and verbose, because you cannot predict what details of your change and reasoning will be important to someone in the future. Because some day someone will read your commit patch and wonder the reasons why you made your changes. I am not applying this patch until the commit message is made more verbose and reasonable. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: David Miller on 1 Jun 2010 03:30
From: <jie.yang(a)atheros.com> Date: Mon, 31 May 2010 14:42:16 +0800 > From: Jie.Yang(a)atheros.com > > Add AR8151 v2.0 Gigabit 1000 support > Change jumbo frame size to 6K > Update L0s/L1 rountine > when link speed is 100M or 1G, set L1 link timer to 4 for l1d_2 and l2c_b2 > set L1 link timer to 7 for l2c_b, set L1 link timer to 0xF for others. > Update atl1c_suspend routine > just refactory the function, add atl1c_phy_power_saving routine, > when Wake On Lan enable, this func will be called to save power, > it will reautoneg PHY to 10/100M speed depend on the link > partners link capability. > Update atl1c_configure_des_ring > do not use l2c_b default SRAM configuration. > > Signed-off-by: Jie.Yang(a)atheros.com Applied, thank you. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ |