blkio: Fix blkio crash during rq stat update
in [Kernel]
|
Prev: [PATCH 1/2] Composite framework: Add suspended sysfs entry
Next: [PATCH] perf: fix initialization bug in parse_single_tracepoint_event()
From: Jens Axboe on 21 Apr 2010 11:50 On Wed, Apr 21 2010, Jens Axboe wrote: > On Wed, Apr 21 2010, Vivek Goyal wrote: > > @@ -1001,6 +1002,11 @@ static struct cfq_group *cfq_get_cfqg(struct cfq_data *cfqd, int create) > > return cfqg; > > } > > > > +static inline struct cfq_group *cfq_ref_get_cfqg(struct cfq_group *cfqg) { > > + atomic_inc(&cfqg->ref); > > + return cfqg; > > +} > > + > > Sorry to keep harping on this - style is still wrong, and: I'll fix these up by hand. -- Jens Axboe -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Vivek Goyal on 21 Apr 2010 11:50 On Wed, Apr 21, 2010 at 05:41:28PM +0200, Jens Axboe wrote: > On Wed, Apr 21 2010, Jens Axboe wrote: > > On Wed, Apr 21 2010, Vivek Goyal wrote: > > > @@ -1001,6 +1002,11 @@ static struct cfq_group *cfq_get_cfqg(struct cfq_data *cfqd, int create) > > > return cfqg; > > > } > > > > > > +static inline struct cfq_group *cfq_ref_get_cfqg(struct cfq_group *cfqg) { > > > + atomic_inc(&cfqg->ref); > > > + return cfqg; > > > +} > > > + > > > > Sorry to keep harping on this - style is still wrong, and: > > I'll fix these up by hand. Thanks Jens. Sorry for the trouble. Vivek > > -- > Jens Axboe -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Jens Axboe on 21 Apr 2010 11:50
On Wed, Apr 21 2010, Vivek Goyal wrote: > @@ -1001,6 +1002,11 @@ static struct cfq_group *cfq_get_cfqg(struct cfq_data *cfqd, int create) > return cfqg; > } > > +static inline struct cfq_group *cfq_ref_get_cfqg(struct cfq_group *cfqg) { > + atomic_inc(&cfqg->ref); > + return cfqg; > +} > + Sorry to keep harping on this - style is still wrong, and: > @@ -3560,6 +3574,9 @@ new_queue: > > rq->elevator_private = cic; > rq->elevator_private2 = cfqq; > + rq->elevator_private3 = cfqq->cfqg; > + /* rq reference on cfqg */ > + cfq_ref_get_cfqg(RQ_CFQG(rq)); > return 0; should be /* hold a reference to the cfqg */ rq->elevator_private3 = cfq_ref_get_cfqg(cfqq->cfqg); -- Jens Axboe -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ |