Prev: linux-next: import failure of the rr quilt series
Next: [BUG][PATCH 0/2 (v.2)] x86: ioremap() problem in X86_32 PAE
From: Mike Frysinger on 16 Jun 2010 21:20
On Wed, Jun 16, 2010 at 9:13 PM, James Bottomley wrote:
> I'm not quite sure whose fault this one is.
>
> However, this code in bnx2.c:
>
> � � � � � � � �if (!get_dma_ops(&pdev->dev)->sync_single_for_cpu) {
> � � � � � � � � � � � �next_rx_buf =
> � � � � � � � � � � � � � � � �&rxr->rx_buf_ring[
> � � � � � � � � � � � � � � � � � � � �RX_RING_IDX(NEXT_RX_BD(sw_cons))];
> � � � � � � � � � � � �prefetch(next_rx_buf->desc);
> � � � � � � � �}
>
> Looks remarkably fragile: what exactly is it trying to do?
>
> The commit that causes the problem:
>
> commit a33fa66bcf365ffe5b79d1ae1d3582cc261ae56e
> Author: Michael Chan <mchan(a)broadcom.com>
> Date: � Thu May 6 08:58:13 2010 +0000
>
> � �bnx2: Add prefetches to rx path.
>
> Looks fairly innocuous by the description.
>
> Should parisc have a get_dma_ops()? �We don't need one because our dma
> ops are per platform not per bus.

looks like it'll be broken on more than just parisc:
$ grep get_dma_ops arch/*/include/asm/ -rl | cut -d/ -f 2
alpha
ia64
microblaze
powerpc
sh
sparc
x86
-mike
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
 | 
Pages: 1
Prev: linux-next: import failure of the rr quilt series
Next: [BUG][PATCH 0/2 (v.2)] x86: ioremap() problem in X86_32 PAE