bsd.perl.mk (Was: Re: _PERL_REFACTORING_COMPLETE lang/perl5.12Mk/bsd.perl.mk)
in [Ports]
|
From: Doug Barton on 20 Jul 2010 01:55 On Tue, 20 Jul 2010, Philip M. Gollucci wrote: > On 07/20/10 04:52, Doug Barton wrote: >> So yeah, a pointyhat run is almost certainly a good idea before actually >> making the change, however 'make index' was the canary in Mark's >> original coal mine, and fortunately that bird is still singing. :) > > Excellent, then your findings and mine agree. So unless we've missed > something would do the honors to send a pr in for an -exp run. That was the purpose of my cc'ing portmgr@ with my findings. If you think a PR is necessary, I'm happy to step aside and let perl@ take over. :) Doug -- Improve the effectiveness of your Internet presence with a domain name makeover! http://SupersetSolutions.com/ Computers are useless. They can only give you answers. -- Pablo Picasso _______________________________________________ freebsd-ports(a)freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-ports To unsubscribe, send any mail to "freebsd-ports-unsubscribe(a)freebsd.org"
From: Mark Linimon on 29 Jul 2010 03:03 On Wed, Jul 28, 2010 at 11:47:11PM -0700, Doug Barton wrote: > When I asked you what was necessary to test this, you said all that was > necessary was to define _PERL_REFACTORING_COMPLETE. And my memory slipped. The explanation, however, was correct: the problem is that if you unconditionally include bsd.perl.mk, everything works, and if you conditionally include it, it doesn't. If you didn't patch the code that does the conditional include, then you didn't test for the actual problem. This is a case of believing the author and/or the documentation, and not looking at the code. I made a mistake; it was not intentional; I'm sorry. mcl _______________________________________________ freebsd-ports(a)freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-ports To unsubscribe, send any mail to "freebsd-ports-unsubscribe(a)freebsd.org"
From: Doug Barton on 29 Jul 2010 03:15
On Thu, 29 Jul 2010, Mark Linimon wrote: > On Wed, Jul 28, 2010 at 11:47:11PM -0700, Doug Barton wrote: >> When I asked you what was necessary to test this, you said all that was >> necessary was to define _PERL_REFACTORING_COMPLETE. > > And my memory slipped. > > The explanation, however, was correct: the problem is that if you > unconditionally include bsd.perl.mk, everything works, and if you > conditionally include it, it doesn't. If you didn't patch the code > that does the conditional include, then you didn't test for the > actual problem. > > This is a case of believing the author and/or the documentation, and > not looking at the 6,408 lines of > code. > > I made a mistake; it was not intentional; I'm sorry. > > mcl > > -- Improve the effectiveness of your Internet presence with a domain name makeover! http://SupersetSolutions.com/ Computers are useless. They can only give you answers. -- Pablo Picasso _______________________________________________ freebsd-ports(a)freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-ports To unsubscribe, send any mail to "freebsd-ports-unsubscribe(a)freebsd.org" |