Prev: ext2/ext3:useless code for return value
Next: perf probe: Support DW_OP_call_frame_cfa in debuginfo
From: Manfred Spraul on 7 May 2010 12:40
Hi Oren,


On 05/01/2010 04:15 PM, Oren Laadan wrote:
> @@ -82,7 +82,7 @@ void shm_init_ns(struct ipc_namespace *ns)
> * Called with shm_ids.rw_mutex (writer) and the shp structure locked.
> * Only shm_ids.rw_mutex remains locked on exit.
> */
> -static void do_shm_rmid(struct ipc_namespace *ns, struct kern_ipc_perm *ipcp)
> +void do_shm_rmid(struct ipc_namespace *ns, struct kern_ipc_perm *ipcp)
> {
> struct shmid_kernel *shp;
> shp = container_of(ipcp, struct shmid_kernel, shm_perm);
>
This hunk appears to be unrelated to the main patch.
Is it intentional or a left-over from debugging?

--
Manfred
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: Oren Laadan on 7 May 2010 13:10


Manfred Spraul wrote:
> Hi Oren,
>
>
> On 05/01/2010 04:15 PM, Oren Laadan wrote:
>> @@ -82,7 +82,7 @@ void shm_init_ns(struct ipc_namespace *ns)
>> * Called with shm_ids.rw_mutex (writer) and the shp structure locked.
>> * Only shm_ids.rw_mutex remains locked on exit.
>> */
>> -static void do_shm_rmid(struct ipc_namespace *ns, struct
>> kern_ipc_perm *ipcp)
>> +void do_shm_rmid(struct ipc_namespace *ns, struct kern_ipc_perm *ipcp)
>> {
>> struct shmid_kernel *shp;
>> shp = container_of(ipcp, struct shmid_kernel, shm_perm);
>>
> This hunk appears to be unrelated to the main patch.
> Is it intentional or a left-over from debugging?
>

Good catch: it belongs in patch 55: "c/r: support shared memory
sysv-ipc". Will move it there. Thanks for the review.

Oren.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
 | 
Pages: 1
Prev: ext2/ext3:useless code for return value
Next: perf probe: Support DW_OP_call_frame_cfa in debuginfo