cgroups: Add an API to attach a task to current task's cgroup
in [Kernel]
|
Prev: [PATCH -mmotm] backlight: fix s6e63m0 device attr function return types
Next: [GIT PULL 0/1] Allow disabling TUI per command in ~/.perfconfig
From: Paul Menage on 20 May 2010 18:30 On Thu, May 20, 2010 at 3:22 PM, Paul Menage <menage(a)google.com> wrote: > On Tue, May 18, 2010 at 5:04 PM, Sridhar Samudrala > <samudrala.sridhar(a)gmail.com> wrote: >> Add a new kernel API to attach a task to current task's cgroup >> in all the active hierarchies. >> >> Signed-off-by: Sridhar Samudrala <sri(a)us.ibm.com> > > Reviewed-by: Paul Menage <menage(a)google.com> > One other thought on this - this would be the first piece of code that's attaching a task to a cgroup without holding the cgroup directory inode i_mutex. I believe that this is probably OK. Paul -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Paul Menage on 25 May 2010 14:40
On Tue, May 25, 2010 at 9:53 AM, Michael S. Tsirkin <mst(a)redhat.com> wrote: > On Thu, May 20, 2010 at 03:22:15PM -0700, Paul Menage wrote: >> On Tue, May 18, 2010 at 5:04 PM, Sridhar Samudrala >> <samudrala.sridhar(a)gmail.com> wrote: >> > Add a new kernel API to attach a task to current task's cgroup >> > in all the active hierarchies. >> > >> > Signed-off-by: Sridhar Samudrala <sri(a)us.ibm.com> >> >> Reviewed-by: Paul Menage <menage(a)google.com> >> >> It would be more efficient to just attach directly to current->cgroups >> rather than potentially creating/destroying one css_set for each >> hierarchy until we've completely converged on current->cgroups - but >> that would require a bunch of refactoring of the guts of >> cgroup_attach_task() to ensure that the right can_attach()/attach() >> callbacks are made. That doesn't really seem worthwhile right now for >> the initial use, that I imagine isn't going to be >> performance-sensitive. >> >> Paul > > Is this patch suitable for 2.6.35? Should be OK, yes. Paul -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ |