cgroups: Add an API to attach a task to current task's cgroup
in [Kernel]
|
Prev: [PATCH] serial: Fix missing bit coverage of ASYNC_FLAGS
Next: ext4: Make sure all the block allocation paths reserve blocks
From: Michael S. Tsirkin on 25 May 2010 13:00 On Thu, May 20, 2010 at 03:22:15PM -0700, Paul Menage wrote: > On Tue, May 18, 2010 at 5:04 PM, Sridhar Samudrala > <samudrala.sridhar(a)gmail.com> wrote: > > Add a new kernel API to attach a task to current task's cgroup > > in all the active hierarchies. > > > > Signed-off-by: Sridhar Samudrala <sri(a)us.ibm.com> > > Reviewed-by: Paul Menage <menage(a)google.com> > > It would be more efficient to just attach directly to current->cgroups > rather than potentially creating/destroying one css_set for each > hierarchy until we've completely converged on current->cgroups - but > that would require a bunch of refactoring of the guts of > cgroup_attach_task() to ensure that the right can_attach()/attach() > callbacks are made. That doesn't really seem worthwhile right now for > the initial use, that I imagine isn't going to be > performance-sensitive. > > Paul Is this patch suitable for 2.6.35? It is needed to fix the case where vhost user might cause a kernel thread to consume more CPU than allowed by the cgroup. Should I just merge it through the vhost tree? Ack for this? Thanks, -- MST -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Michael S. Tsirkin on 27 May 2010 05:30
On Tue, May 25, 2010 at 11:34:12AM -0700, Paul Menage wrote: > On Tue, May 25, 2010 at 9:53 AM, Michael S. Tsirkin <mst(a)redhat.com> wrote: > > On Thu, May 20, 2010 at 03:22:15PM -0700, Paul Menage wrote: > >> On Tue, May 18, 2010 at 5:04 PM, Sridhar Samudrala > >> <samudrala.sridhar(a)gmail.com> wrote: > >> > Add a new kernel API to attach a task to current task's cgroup > >> > in all the active hierarchies. > >> > > >> > Signed-off-by: Sridhar Samudrala <sri(a)us.ibm.com> > >> > >> Reviewed-by: Paul Menage <menage(a)google.com> > >> > >> It would be more efficient to just attach directly to current->cgroups > >> rather than potentially creating/destroying one css_set for each > >> hierarchy until we've completely converged on current->cgroups - but > >> that would require a bunch of refactoring of the guts of > >> cgroup_attach_task() to ensure that the right can_attach()/attach() > >> callbacks are made. That doesn't really seem worthwhile right now for > >> the initial use, that I imagine isn't going to be > >> performance-sensitive. > >> > >> Paul > > > > Is this patch suitable for 2.6.35? > > Should be OK, yes. > > Paul So I'll add your Acked-by tag then, and merge through the vhost tree together with the patch that uses this. -- MST -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ |