char: Convert pci_table entries to PCI_VDEVICE (if PCI_ANY_ID is used)
in [Kernel]
|
Prev: char: Convert pci_table entries to PCI_VDEVICE (if PCI_ANY_ID is used)
Next: Linux 2.6.28.10 and Linux 2.6.29.6 XEN Guest Support Broken x86_64 in BUILD
From: Joe Perches on 15 Jul 2010 17:10 On Thu, 2010-07-15 at 13:45 -0700, Greg KH wrote: > I much prefer the PCI_DEVICE() macro instead, and as such, I'm not > willing to take any of these patches, sorry. grepping for pci device ids using constants and expecting the result to be comprehensive isn't sensible. $ grep -rwP --include=*.[ch] -w PCI_VDEVICE drivers/char | wc -l 32 The current drivers/ use of PCI_VDEVICE to PCI_DEVICE is ~50/50 $ grep --include=*.[ch] -rwP PCI_DEVICE drivers | wc -l 866 $ grep --include=*.[ch] -rwP PCI_VDEVICE drivers | wc -l 768 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Joe Perches on 16 Jul 2010 00:50 On Thu, 2010-07-15 at 21:29 -0700, Greg KH wrote: > On Thu, Jul 15, 2010 at 02:00:15PM -0700, Joe Perches wrote: > > On Thu, 2010-07-15 at 13:45 -0700, Greg KH wrote: > > > I much prefer the PCI_DEVICE() macro instead, and as such, I'm not > > > willing to take any of these patches, sorry. > > grepping for pci device ids using constants and > > expecting the result to be comprehensive isn't > > sensible. > But it's a nice goal :) I think your goal is not a good one. For instance: $ grep -rP --include=*.[ch] "\bPCI_VDEVICE\s*\(\s*INTEL" drivers | wc -l 201 $ grep -rP --include=*.[ch] "\bPCI_DEVICE\s*\(PCI_VENDOR_ID_INTEL" drivers | wc -l 45 $ grep -rP --include=*.[ch] "\bPCI_DEVICE\s*\(\s*0x8086" drivers | wc -l 38 I'd much rather do a search for "PCI_VDEVICE.*INTEL" -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Joe Perches on 16 Jul 2010 01:40
On Thu, 2010-07-15 at 22:29 -0700, Greg KH wrote: > On Thu, Jul 15, 2010 at 09:44:23PM -0700, Joe Perches wrote: > > On Thu, 2010-07-15 at 21:29 -0700, Greg KH wrote: > > > On Thu, Jul 15, 2010 at 02:00:15PM -0700, Joe Perches wrote: > > > > On Thu, 2010-07-15 at 13:45 -0700, Greg KH wrote: > > > > > I much prefer the PCI_DEVICE() macro instead, and as such, I'm not > > > > > willing to take any of these patches, sorry. > > > > grepping for pci device ids using constants and > > > > expecting the result to be comprehensive isn't > > > > sensible. > > > But it's a nice goal :) > > I think your goal is not a good one. > > > > For instance: > > > > $ grep -rP --include=*.[ch] "\bPCI_VDEVICE\s*\(\s*INTEL" drivers | wc -l > > 201 > > $ grep -rP --include=*.[ch] "\bPCI_DEVICE\s*\(PCI_VENDOR_ID_INTEL" drivers | wc -l > > 45 > > $ grep -rP --include=*.[ch] "\bPCI_DEVICE\s*\(\s*0x8086" drivers | wc -l > > 38 > > I'd much rather do a search for "PCI_VDEVICE.*INTEL" > I'd much rather use 'cscope' or 'ctags' than trying to remember regular > expressions like the above. Then it appears your original argument doesn't have much merit. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ |