classmate-laptop: fix for RFKILL=m, CMPC=y
in [Kernel]
|
Prev: Timekeeping issue on aggressive suspend/resume
Next: [PATCH] pci: Don't enable aspm before drivers have had a chance to veto it
From: Randy Dunlap on 9 Jun 2010 16:10 On 06/09/10 13:02, Thadeu Lima de Souza Cascardo wrote: > On Thu, Jun 03, 2010 at 09:39:03AM -0700, Randy Dunlap wrote: >> From: Randy Dunlap <randy.dunlap(a)oracle.com> >> >> Fix build error when CONFIG_RFKILL=m and CONFIG_ACPI_CMPC=y: >> classmate-laptop should depend on RFKILL or RFKILL=n. >> >> classmate-laptop.c:(.text+0x1351fc): undefined reference to `rfkill_unregister' >> classmate-laptop.c:(.text+0x135204): undefined reference to `rfkill_destroy' >> classmate-laptop.c:(.text+0x135237): undefined reference to `rfkill_set_sw_state' >> classmate-laptop.c:(.text+0x1352b9): undefined reference to `rfkill_alloc' >> classmate-laptop.c:(.text+0x1352ca): undefined reference to `rfkill_register' >> classmate-laptop.c:(.text+0x1352d6): undefined reference to `rfkill_destroy' >> >> Signed-off-by: Randy Dunlap <randy.dunlap(a)oracle.com> >> --- > > > Randy, > > Since this implies a build failure, shouldn't it be sent for rc too? Yes, it should. I hit the problem during a linux-next build, but it does apply to mainline as well. Thanks. >> drivers/platform/x86/Kconfig | 1 + >> 1 file changed, 1 insertion(+) >> >> --- linux-next-20100603.orig/drivers/platform/x86/Kconfig >> +++ linux-next-20100603/drivers/platform/x86/Kconfig >> @@ -520,6 +520,7 @@ config TOSHIBA_BT_RFKILL >> config ACPI_CMPC >> tristate "CMPC Laptop Extras" >> depends on X86 && ACPI >> + depends on RFKILL || RFKILL=n >> select INPUT >> select BACKLIGHT_CLASS_DEVICE >> default n -- ~Randy *** Remember to use Documentation/SubmitChecklist when testing your code *** -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Thadeu Lima de Souza Cascardo on 9 Jun 2010 16:10 On Thu, Jun 03, 2010 at 09:39:03AM -0700, Randy Dunlap wrote: > From: Randy Dunlap <randy.dunlap(a)oracle.com> > > Fix build error when CONFIG_RFKILL=m and CONFIG_ACPI_CMPC=y: > classmate-laptop should depend on RFKILL or RFKILL=n. > > classmate-laptop.c:(.text+0x1351fc): undefined reference to `rfkill_unregister' > classmate-laptop.c:(.text+0x135204): undefined reference to `rfkill_destroy' > classmate-laptop.c:(.text+0x135237): undefined reference to `rfkill_set_sw_state' > classmate-laptop.c:(.text+0x1352b9): undefined reference to `rfkill_alloc' > classmate-laptop.c:(.text+0x1352ca): undefined reference to `rfkill_register' > classmate-laptop.c:(.text+0x1352d6): undefined reference to `rfkill_destroy' > > Signed-off-by: Randy Dunlap <randy.dunlap(a)oracle.com> > --- Randy, Since this implies a build failure, shouldn't it be sent for rc too? Best Regards, Cascardo. > drivers/platform/x86/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > --- linux-next-20100603.orig/drivers/platform/x86/Kconfig > +++ linux-next-20100603/drivers/platform/x86/Kconfig > @@ -520,6 +520,7 @@ config TOSHIBA_BT_RFKILL > config ACPI_CMPC > tristate "CMPC Laptop Extras" > depends on X86 && ACPI > + depends on RFKILL || RFKILL=n > select INPUT > select BACKLIGHT_CLASS_DEVICE > default n
From: Matthew Garrett on 9 Jun 2010 16:20
On Wed, Jun 09, 2010 at 01:05:04PM -0700, Randy Dunlap wrote: > On 06/09/10 13:02, Thadeu Lima de Souza Cascardo wrote: > > Since this implies a build failure, shouldn't it be sent for rc too? > > Yes, it should. > I hit the problem during a linux-next build, but it does apply to mainline as well. > Thanks. It's been sent upstream, but Linus didn't pull. I'll see if I can find a set he's willing to take. -- Matthew Garrett | mjg59(a)srcf.ucam.org -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ |