Prev: CRYPTO: ablkcipher, avoid NULL dereference
Next: [PATCH -mm 1/6] mmap: remove unnecessary lock from __vma_link
From: Ryan Mallon on 21 Jun 2010 16:50
On 06/21/2010 05:35 PM, Jeremy Kerr wrote:
> Since most platforms will need a fixed-rate clock, add one. This will
> also serve as a basic example of an implementation of struct clk.
>
> Signed-off-by: Jeremy Kerr <jeremy.kerr(a)canonical.com>
>
> ---
> include/linux/clk.h | 13 +++++++++++++
> kernel/clk.c | 14 ++++++++++++++
> 2 files changed, 27 insertions(+)
>
> diff --git a/include/linux/clk.h b/include/linux/clk.h
> index 5c1098b..1dce473 100644
> --- a/include/linux/clk.h
> +++ b/include/linux/clk.h
> @@ -79,6 +79,19 @@ struct clk_ops {
> */
> int __clk_get(struct clk *clk);
>
> +/* Simple fixed-rate clock */
> +struct clk_fixed {
> + struct clk clk;
> + unsigned long rate;
> +};

Not sure if this has been discussed already, but shouldn't rate be const
for a fixed clock?

~Ryan

--
Bluewater Systems Ltd - ARM Technology Solution Centre

Ryan Mallon 5 Amuri Park, 404 Barbadoes St
ryan(a)bluewatersys.com PO Box 13 889, Christchurch 8013
http://www.bluewatersys.com New Zealand
Phone: +64 3 3779127 Freecall: Australia 1800 148 751
Fax: +64 3 3779135 USA 1800 261 2934
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: Jeremy Kerr on 21 Jun 2010 21:10
Hi Ryan,

> Not sure if this has been discussed already, but shouldn't rate be const
> for a fixed clock?

No, we may need to set the rate at some point - eg, when setting up the
clocks, or parsing from the device tree.

Cheers,


Jeremy
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
 | 
Pages: 1
Prev: CRYPTO: ablkcipher, avoid NULL dereference
Next: [PATCH -mm 1/6] mmap: remove unnecessary lock from __vma_link