debug log in pg_archivecleanup

Prev: to enable O_DIRECT within postgresql
Next: [v9.1] Add security hook on initialization of instance

From: Takahiro Itagaki on 15 Jun 2010 23:24

---

Fujii Masao <masao.fujii(a)gmail.com> wrote:

> This is because pg_archivecleanup puts the line break "\n" in the head of
> debug message. Why should we do so?
>
> -----------------------
> if (debug)
> fprintf(stderr, "\n%s: removing \"%s\"", progname, WALFilePath);
> -----------------------

We also need "\n" at line 308.
L.125: fprintf(stderr, "\n%s: removing \"%s\"", progname, WALFilePath);
L.308: fprintf(stderr, "%s: keep WAL file %s and later", progname, exclusiveCleanupFileName);

Note that we don't need a line break at Line 130
because strerror() fills the last %s.
L.130: fprintf(stderr, "\n%s: ERROR failed to remove \"%s\": %s",

Regards,
---
Takahiro Itagaki
NTT Open Source Software Center



--
Sent via pgsql-hackers mailing list (pgsql-hackers(a)postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

From: Fujii Masao on 17 Jun 2010 02:26

---

On Wed, Jun 16, 2010 at 12:24 PM, Takahiro Itagaki
<itagaki.takahiro(a)oss.ntt.co.jp> wrote:
>
> Fujii Masao <masao.fujii(a)gmail.com> wrote:
>
>> This is because pg_archivecleanup puts the line break "\n" in the head of
>> debug message. Why should we do so?
>>
>> -----------------------
>>  if (debug)
>>     fprintf(stderr, "\n%s:  removing \"%s\"", progname, WALFilePath);
>> -----------------------
>
> We also need "\n" at line 308.
>  L.125: fprintf(stderr, "\n%s:  removing \"%s\"", progname, WALFilePath);
>  L.308: fprintf(stderr, "%s:  keep WAL file %s and later", progname, exclusiveCleanupFileName);

Yes. What about the attached patch?

> Note that we don't need a line break at Line 130
> because strerror() fills the last %s.
>  L.130: fprintf(stderr, "\n%s: ERROR failed to remove \"%s\": %s",

Right.

Regards,

--
Fujii Masao
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center

From: Tom Lane on 17 Jun 2010 13:33

---

Fujii Masao <masao.fujii(a)gmail.com> writes:
> On Wed, Jun 16, 2010 at 12:24 PM, Takahiro Itagaki
> <itagaki.takahiro(a)oss.ntt.co.jp> wrote:
>> This is because pg_archivecleanup puts the line break "\n" in the head of
>> debug message. Why should we do so?

> Yes. What about the attached patch?

Applied along with a bit of further editorialization.

>> Note that we don't need a line break at Line 130
>> because strerror() fills the last %s.
>> �L.130: fprintf(stderr, "\n%s: ERROR failed to remove \"%s\": %s",

> Right.

Huh? strerror() doesn't include a newline.

regards, tom lane

--
Sent via pgsql-hackers mailing list (pgsql-hackers(a)postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

From: Simon Riggs on 18 Jun 2010 04:51

---

On Thu, 2010-06-17 at 13:33 -0400, Tom Lane wrote:
> Fujii Masao <masao.fujii(a)gmail.com> writes:
> > On Wed, Jun 16, 2010 at 12:24 PM, Takahiro Itagaki
> > <itagaki.takahiro(a)oss.ntt.co.jp> wrote:
> >> This is because pg_archivecleanup puts the line break "\n" in the head of
> >> debug message. Why should we do so?
>
> > Yes. What about the attached patch?
>
> Applied along with a bit of further editorialization.
>
> >> Note that we don't need a line break at Line 130
> >> because strerror() fills the last %s.
> >> L.130: fprintf(stderr, "\n%s: ERROR failed to remove \"%s\": %s",
>
> > Right.
>
> Huh? strerror() doesn't include a newline.

Thanks.

--
Simon Riggs www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Training and Services


--
Sent via pgsql-hackers mailing list (pgsql-hackers(a)postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

 | 
Pages: 1
Prev: to enable O_DIRECT within postgresql
Next: [v9.1] Add security hook on initialization of instance