Prev: m68knommu: driver for Freescale Coldfire I2C controller.
Next: [PATCH] ide: Build break in ide-iops.c
From: Greg KH on 16 Mar 2010 16:20
On Tue, Mar 16, 2010 at 08:14:05PM +0100, Peter Korsgaard wrote:
> >>>>> "Greg" == Greg KH <greg(a)kroah.com> writes:
>
> Hi,
>
> >> config DEVTMPFS
> >> bool "Maintain a devtmpfs filesystem to mount at /dev"
> >> - depends on HOTPLUG && SHMEM && TMPFS
> >> + depends on HOTPLUG
> >> help
> >> This creates a tmpfs filesystem instance early at bootup.
> >> In this filesystem, the kernel driver core maintains device
>
> Greg> With this patch, the Kconfig help text now is incorrect.
>
> Greg> Is there a way to explicitly call out in the Kconfig which way
> Greg> devtmpfs is being created? How about a multiple selection that
> Greg> chooses either TMPFS or RAMFS, with the default being TMPFS?
>
> I don't think that's needed - If CONFIG_TMPFS isn't set, then ramfs
> pretends to be tmpfs anyway, see mm/shmem.c:
>
> static struct file_system_type tmpfs_fs_type = {
> .name = "tmpfs",
> .get_sb = ramfs_get_sb,
> .kill_sb = kill_litter_super,
> };
>
> So calling it tmpfs isn't really wrong.

Heh, wow, I didn't realize that.

> Greg> So care to redo this so that people can easily determine what is going
> Greg> to happen easier than this patch currently causes?
>
> We can change the help text to say tmpfs/ramfs if you prefer - OK?

Yes, maybe with an explaination that if TMPFS is not set, ramfs will be
used.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
First  |  Prev  | 
Pages: 1 2
Prev: m68knommu: driver for Freescale Coldfire I2C controller.
Next: [PATCH] ide: Build break in ide-iops.c