Prev: hangcheck-timer is broken on x86
Next: [PATCH 5/7] arch/powerpc/kernel: Use set_cpus_allowed_ptr
From: Chris Wright on 26 Mar 2010 18:00
* Henrik Kretzschmar (henne(a)nachtwindheim.de) wrote:
> This patch fixes a section mismatch.
>
> WARNING: drivers/pci/built-in.o(.text+0x182f5): Section mismatch in
> reference from the function dmar_ir_support() to the variable
> .init.data:acpi_slot_detected
> The function dmar_ir_support() references
> the variable __initdata acpi_slot_detected.
> This is often because dmar_ir_support lacks a __initdata
> annotation or the annotation of acpi_slot_detected is wrong.
>
> Signed-off-by: Henrik Kretzschmar <henne(a)nachtwindheim.de>

Acked-by: Chris Wright <chrisw(a)sous-sol.org>

> -int dmar_ir_support(void)
> +int __init dmar_ir_support(void)

> -extern int dmar_ir_support(void);
> +extern int dmar_ir_support(void) __init;

Nit, but prerfer to see:

-extern int dmar_ir_support(void);
+extern int __init dmar_ir_support(void);

thanks,
-chris
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
 | 
Pages: 1
Prev: hangcheck-timer is broken on x86
Next: [PATCH 5/7] arch/powerpc/kernel: Use set_cpus_allowed_ptr