doc: watchdog simple example: don't fail on fsync()
in [Kernel]
|
Prev: keyctl_session_to_parent: use thread_group_empty() to check singlethreadness
Next: [PATCH] hwmon: f71882fg: acquire I/O regions while we're working with them
From: Giel van Schijndel on 24 Mar 2010 05:10 On Mon, Mar 22, 2010 at 01:22:37PM +0100, Giel van Schijndel wrote: > Don't terminate the watchdog daemon when fsync() fails because no > watchdog driver actually implements the fsync() syscall. > --- > Documentation/watchdog/src/watchdog-simple.c | 5 ++++- > 1 files changed, 4 insertions(+), 1 deletions(-) Seems I forgot to sign off my own patch: Signed-off-by: Giel van Schijndel <me(a)mortis.eu> -- Met vriendelijke groet, With kind regards, Giel van Schijndel
From: Wim Van Sebroeck on 29 Mar 2010 14:50 Hi Giel, > Don't terminate the watchdog daemon when fsync() fails because no > watchdog driver actually implements the fsync() syscall. Wouldn't it be simpler then to just do an fsync without checking the error-result? Kind regards, Wim. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Giel van Schijndel on 29 Mar 2010 15:20
On Mon, Mar 29, 2010 at 08:40:41PM +0200, Wim Van Sebroeck wrote: >> Don't terminate the watchdog daemon when fsync() fails because no >> watchdog driver actually implements the fsync() syscall. > > Wouldn't it be simpler then to just do an fsync without checking the error-result? Yes, it definitly would be. Though I think it would be even simpler to simply ditch the fsync() call. Considering that none of the watchdog drivers implements it, nor can I think of a usecase where it would make sense to implement (as more than a NOP). So instead I suggest the patch following this line: ======================================================================== doc: watchdog simple example: don't fail on fsync() Don't terminate the watchdog daemon when fsync() fails because no watchdog driver actually implements the fsync() syscall. Signed-off-by: Giel van Schijndel <me(a)mortis.eu> --- Documentation/watchdog/src/watchdog-simple.c | 3 --- 1 files changed, 0 insertions(+), 3 deletions(-) diff --git a/Documentation/watchdog/src/watchdog-simple.c b/Documentation/watchdog/src/watchdog-simple.c index 4cf72f3..ba45803 100644 --- a/Documentation/watchdog/src/watchdog-simple.c +++ b/Documentation/watchdog/src/watchdog-simple.c @@ -17,9 +17,6 @@ int main(void) ret = -1; break; } - ret = fsync(fd); - if (ret) - break; sleep(10); } close(fd); -- 1.6.4.4 -- Met vriendelijke groet, With kind regards, Giel van Schijndel |