Prev: [PATCH] ftrace: add documentation for trace commands mod, traceon/traceoff
Next: [PATCH] sdhci-pltfm: Add kernel-doc for struct sdhci_pltfm_data
From: Rafael J. Wysocki on 23 Apr 2010 14:30 On Monday 05 April 2010, Pavel Machek wrote: > Hi! > > > > > Please note that merely _opening_ /dev/snapshot has side effects, so that's > > > > not just "three ioctls". > > > > > > I search Doc*/power/userland-swsusp.txt, and could not find mentions > > > of sideeffects. Perhaps that should be fixed? > > > > Please feel free to make the docs more complete, then. > > Yes, something like this? Yes, looks reasonable. I've applied it to suspend-2.6/linux-next (added a changelog). Rafael > Signed-off-by: Pavel Machek <pavel(a)ucw.cz> > > --- a/Documentation/power/userland-swsusp.txt > +++ b/Documentation/power/userland-swsusp.txt > @@ -24,6 +24,10 @@ assumed to be in the resume mode. The device cannot be open for simultaneous > reading and writing. It is also impossible to have the device open more than > once at a time. > > +Even opening the device has side effects. Data structures are > +allocated, and PM_HIBERNATION_PREPARE / PM_RESTORE_PREPARE chains are > +called. > + > The ioctl() commands recognized by the device are: > > SNAPSHOT_FREEZE - freeze user space processes (the current process is > > > > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ |