drivers/block/aoe: Use kmemdup
in [Kernel]
|
Prev: [PATCH 2.6.34-rc7 v2] HID: hid-samsung: add support for Creative Desktop Wireless 6000
Next: x86: CPU detection for RDC System-on-Chip
From: Ed Cashin on 16 May 2010 09:00 On May 15, 2010, at 5:23 PM, Julia Lawall wrote: > From: Julia Lawall <julia(a)diku.dk> > > Use kmemdup when some other buffer is immediately copied into the > allocated region. I have seen this patch but have no comment about it specifically. (Because the argument about whether this kind of change adds value in general has already taken place. I'd say no, but that's based on a maybe faulty idea that if folks weren't doing this they'd have more time for reviewing patches, etc.) -- Ed Cashin ecashin(a)coraid.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Dan Carpenter on 16 May 2010 12:00 On Sun, May 16, 2010 at 08:42:59AM -0400, Ed Cashin wrote: > On May 15, 2010, at 5:23 PM, Julia Lawall wrote: > > > From: Julia Lawall <julia(a)diku.dk> > > > > Use kmemdup when some other buffer is immediately copied into the > > allocated region. > > I have seen this patch but have no comment about it specifically. > > (Because the argument about whether this kind of change > adds value in general has already taken place. I'd say no, but that's > based on a maybe faulty idea that if folks weren't doing this they'd have > more time for reviewing patches, etc.) Nah nah. Nit-picky patches like this is what you get when people start reviewing code. It's really hard to review code properly without being annoyed and writing clean up patches is very calming. git log --pretty=oneline --grep=Lawall Tons and tons of bugs fixed. regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Julia Lawall on 16 May 2010 12:10 On Sun, 16 May 2010, Dan Carpenter wrote: > On Sun, May 16, 2010 at 08:42:59AM -0400, Ed Cashin wrote: > > On May 15, 2010, at 5:23 PM, Julia Lawall wrote: > > > > > From: Julia Lawall <julia(a)diku.dk> > > > > > > Use kmemdup when some other buffer is immediately copied into the > > > allocated region. > > > > I have seen this patch but have no comment about it specifically. > > > > (Because the argument about whether this kind of change > > adds value in general has already taken place. I'd say no, but that's > > based on a maybe faulty idea that if folks weren't doing this they'd have > > more time for reviewing patches, etc.) > > Nah nah. Nit-picky patches like this is what you get when people start > reviewing code. It's really hard to review code properly without being > annoyed and writing clean up patches is very calming. Actually, someone asked me to convery a kmalloc to kstrdup, and I saw kmemdup nearby, and thought why not... There is also the similar memdup_user. Using that would more significantly simplify the code, in particular reducing the amount of error handling code, since it encompasses two calls that can fail (kmalloc and copy_from_user). julia -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Pekka Enberg on 16 May 2010 12:50
On Sun, May 16, 2010 at 3:42 PM, Ed Cashin <ecashin(a)coraid.com> wrote: > (Because the argument about whether this kind of change > adds value in general has already taken place. �I'd say no, but that's > based on a maybe faulty idea that if folks weren't doing this they'd have > more time for reviewing patches, etc.) It makes kernel text size smaller so yes, it adds value. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ |