Prev: tracing: fixes and documentation updates
Next: CBQ broken in 2.6
From: Jiri Slaby on 27 Jan 2010 04:40
On 01/27/2010 01:37 AM, akpm(a)linux-foundation.org wrote:
> Subject: drivers/block/floppy.c: remove used once CHECK_READY macro
> From: Joe Perches <joe(a)perches.com>

That the macro is used once does not necessarily mean, it should be
removed. Please add more explanation to your changelogs. It should be
something like: "remove the macro as it is totally bogus in that it
changes control flow and we usually do not expect that". For example,
there were alerady few macro incidents in floppy that changed control
flow causing locking imbalances.

--
js
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
 | 
Pages: 1
Prev: tracing: fixes and documentation updates
Next: CBQ broken in 2.6