Prev: [PATCH 1/2] e1000e: Only disable ASPM on 82573L devices
Next: [PATCH 2/2] e1000e: Don't disable jumbo frames on 82537L due to eeprom contents
From: Greg KH on 9 Feb 2010 18:10
On Tue, Feb 09, 2010 at 11:59:07PM +0100, Jochen Maes wrote:
> Fixed Codestyle issues
>
> Signed-off-by: Jochen Maes <jochen.maes(a)sejo.be>
> ---
> drivers/staging/dream/pmem.c | 26 ++++++++++++--------------
> 1 files changed, 12 insertions(+), 14 deletions(-)
>
> diff --git a/drivers/staging/dream/pmem.c b/drivers/staging/dream/pmem.c
> index def6468..ec4e7d1 100644
> --- a/drivers/staging/dream/pmem.c
> +++ b/drivers/staging/dream/pmem.c
> @@ -37,17 +37,17 @@
> * the file should not be released until put_pmem_file is called */
> #define PMEM_FLAGS_BUSY 0x1
> /* indicates that this is a suballocation of a larger master range */
> -#define PMEM_FLAGS_CONNECTED 0x1 << 1
> +#define PMEM_FLAGS_CONNECTED { 0x1 << 1 }

Shouldn't this be using a ( ) and not { } ?

> /* indicates this is a master and not a sub allocation and that it is mmaped */
> -#define PMEM_FLAGS_MASTERMAP 0x1 << 2
> +#define PMEM_FLAGS_MASTERMAP { 0x1 << 2 }
> /* submap and unsubmap flags indicate:
> * 00: subregion has never been mmaped
> * 10: subregion has been mmaped, reference to the mm was taken
> * 11: subretion has ben released, refernece to the mm still held
> * 01: subretion has been released, reference to the mm has been released
> */
> -#define PMEM_FLAGS_SUBMAP 0x1 << 3
> -#define PMEM_FLAGS_UNSUBMAP 0x1 << 4
> +#define PMEM_FLAGS_SUBMAP { 0x1 << 3 }
> +#define PMEM_FLAGS_UNSUBMAP { 0x1 << 4 }

Same for these.

> @@ -152,7 +152,7 @@ struct pmem_info {
> static struct pmem_info pmem[PMEM_MAX_DEVICES];
> static int id_count;
>
> -#define PMEM_IS_FREE(id, index) !(pmem[id].bitmap[index].allocated)
> +#define PMEM_IS_FREE(id, index) { !(pmem[id].bitmap[index].allocated) }

And this.

care to fix this up and resend the patch?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
 | 
Pages: 1
Prev: [PATCH 1/2] e1000e: Only disable ASPM on 82573L devices
Next: [PATCH 2/2] e1000e: Don't disable jumbo frames on 82537L due to eeprom contents