drivers/infiniband/hw/nes: Adjust confusing if indentation
in [Kernel]
|
Prev: [GIT PULL] x86/build for 2.6.36
Next: [PATCH 37/42] drivers/net/hamradio: Adjust confusing if indentation
From: Roland Dreier on 5 Aug 2010 16:40 > It is not clear whether the assignment should be part of the if branch > suggested by its indentation. The patch preserves the current semantics. Thanks. Chien/Faisal -- are the current semantics correct or should we add braces { } to match the indentation? From a quick look at the code, I think the patch we actually want is: drivers/infiniband/hw/nes/nes_hw.c | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/infiniband/hw/nes/nes_hw.c b/drivers/infiniband/hw/nes/nes_hw.c index 07c4004..f8233c8 100644 --- a/drivers/infiniband/hw/nes/nes_hw.c +++ b/drivers/infiniband/hw/nes/nes_hw.c @@ -2737,9 +2737,9 @@ void nes_nic_ce_handler(struct nes_device *nesdev, struct nes_hw_nic_cq *cq) nesnic->sq_tail &= nesnic->sq_size-1; if (sq_cqes > 128) { barrier(); - /* restart the queue if it had been stopped */ - if (netif_queue_stopped(nesvnic->netdev)) - netif_wake_queue(nesvnic->netdev); + /* restart the queue if it had been stopped */ + if (netif_queue_stopped(nesvnic->netdev)) + netif_wake_queue(nesvnic->netdev); sq_cqes = 0; } } else { -- Roland Dreier <rolandd(a)cisco.com> || For corporate legal information go to: http://www.cisco.com/web/about/doing_business/legal/cri/index.html -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ |