Prev: x86, cpufeature: Suppress compiler warning with gcc 3.x
Next: [PATCH 2/2] menuconfig: truncate list items
From: Scott Feldman on 3 Jun 2010 03:30
On 6/2/10 8:30 AM, "Joe Perches" <joe(a)perches.com> wrote:

> Compile tested only
>
> Add #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
> Remove #define PFX
> Use pr_<level>
> Use netdev_<level>
> Remove trailing periods from most formats
>
> Signed-off-by: Joe Perches <joe(a)perches.com>

Thanks Joe. I tested it and there are a couple places before the netdev is
registered where we need dev_<level> rather than netdev_<level>, otherwise
we get output like:

enic 0000:08:00.0: (unregistered net_device): vNIC MAC addr
00:25:b5:19:35:8f wq/rq 256/512

I like the dev_name(dev) in there but not the "(unregister net_device)".

Also there where a couple of lines longer than 80 chars.

We can fix up the patch and resubmit if you like.

-scott

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
 | 
Pages: 1
Prev: x86, cpufeature: Suppress compiler warning with gcc 3.x
Next: [PATCH 2/2] menuconfig: truncate list items