Prev: [PATCH 2/3] tracing: Remove special traces
Next: [PATCH RFC 03/12] x86/ticketlock: Use C for __ticket_spin_unlock
From: Jiri Kosina on 20 Jul 2010 11:40
On Sat, 3 Jul 2010, Kulikov Vasiliy wrote:

> Use for_each_pci_dev() to simplify the code.
>
> Signed-off-by: Kulikov Vasiliy <segooon(a)gmail.com>
> ---
> drivers/net/irda/smsc-ircc2.c | 5 +----
> 1 files changed, 1 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/net/irda/smsc-ircc2.c b/drivers/net/irda/smsc-ircc2.c
> index d67e484..850ca1c 100644
> --- a/drivers/net/irda/smsc-ircc2.c
> +++ b/drivers/net/irda/smsc-ircc2.c
> @@ -2848,9 +2848,7 @@ static int __init smsc_ircc_preconfigure_subsystems(unsigned short ircc_cfg,
> unsigned short ss_device = 0x0000;
> int ret = 0;
>
> - dev = pci_get_device(PCI_ANY_ID, PCI_ANY_ID, dev);
> -
> - while (dev != NULL) {
> + for_each_pci_dev(dev) {
> struct smsc_ircc_subsystem_configuration *conf;
>
> /*
> @@ -2899,7 +2897,6 @@ static int __init smsc_ircc_preconfigure_subsystems(unsigned short ircc_cfg,
> ret = -ENODEV;
> }
> }
> - dev = pci_get_device(PCI_ANY_ID, PCI_ANY_ID, dev);
> }
>
> return ret;

Doesn't seem to hit linux-next as of today. Dave, are you going to merge
it?

Thanks,

--
Jiri Kosina
SUSE Labs, Novell Inc.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: David Miller on 21 Jul 2010 17:10
From: Jiri Kosina <jkosina(a)suse.cz>
Date: Tue, 20 Jul 2010 17:33:01 +0200 (CEST)

> On Sat, 3 Jul 2010, Kulikov Vasiliy wrote:
>
>> Use for_each_pci_dev() to simplify the code.
>>
>> Signed-off-by: Kulikov Vasiliy <segooon(a)gmail.com>
>> ---
....
> Doesn't seem to hit linux-next as of today. Dave, are you going to merge
> it?

I'll apply this now, thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
 | 
Pages: 1
Prev: [PATCH 2/3] tracing: Remove special traces
Next: [PATCH RFC 03/12] x86/ticketlock: Use C for __ticket_spin_unlock