drivers/net/mac8390.c: Remove useless memcpy casting
in [Kernel]
|
Prev: ALSA: hda - Add ASRock mobo to MSI blacklist
Next: staging/pohmelfs: fix write_inode parameter warning
From: Geert Uytterhoeven on 7 Mar 2010 04:20 On Tue, Mar 2, 2010 at 21:01, Linux Kernel Mailing List <linux-kernel(a)vger.kernel.org> wrote: > Gitweb: http://git.kernel.org/linus/5c7fffd0e3b57cb63f50bbd710868f012d67654f > Commit: 5c7fffd0e3b57cb63f50bbd710868f012d67654f > Parent: 35076402a9936fa8a73b57a1f97fecbeceeec34a > Author: Joe Perches <joe(a)perches.com> > AuthorDate: Mon Jan 4 11:53:00 2010 +0000 > Committer: David S. Miller <davem(a)davemloft.net> > CommitDate: Wed Jan 6 20:44:02 2010 -0800 > > drivers/net/mac8390.c: Remove useless memcpy casting > > Signed-off-by: Joe Perches <joe(a)perches.com> > Signed-off-by: David S. Miller <davem(a)davemloft.net> > --- > drivers/net/mac8390.c | 19 ++++++++++--------- > 1 files changed, 10 insertions(+), 9 deletions(-) > > diff --git a/drivers/net/mac8390.c b/drivers/net/mac8390.c > index 6b6f375..517cee4 100644 > --- a/drivers/net/mac8390.c > +++ b/drivers/net/mac8390.c > @@ -237,14 +237,14 @@ static enum mac8390_access __init mac8390_testio(volatile unsigned long membase) As indicated by the prototype above, membase is not a pointer... > unsigned long outdata = 0xA5A0B5B0; > unsigned long indata = 0x00000000; > /* Try writing 32 bits */ > - memcpy((char *)membase, (char *)&outdata, 4); > + memcpy(membase, &outdata, 4); > /* Now compare them */ > if (memcmp((char *)&outdata, (char *)membase, 4) == 0) > return ACCESS_32; > /* Write 16 bit output */ > - word_memcpy_tocard((char *)membase, (char *)&outdata, 4); > + word_memcpy_tocard(membase, &outdata, 4); > /* Now read it back */ > - word_memcpy_fromcard((char *)&indata, (char *)membase, 4); > + word_memcpy_fromcard(&indata, membase, 4); > if (outdata == indata) > return ACCESS_16; > return ACCESS_UNKNOWN; .... hence you introduced 3 compiler warnings: drivers/net/mac8390.c:249: warning: passing argument 1 of '__builtin_memcpy' makes pointer from integer without a cast drivers/net/mac8390.c:254: warning: passing argument 1 of 'word_memcpy_tocard' makes pointer from integer without a cast drivers/net/mac8390.c:256: warning: passing argument 2 of 'word_memcpy_fromcard' makes pointer from integer without a cast Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert(a)linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Joe Perches on 8 Mar 2010 11:20
On Sun, 2010-03-07 at 10:19 +0100, Geert Uytterhoeven wrote: > ... hence you introduced 3 compiler warnings: > > drivers/net/mac8390.c:249: warning: passing argument 1 of > '__builtin_memcpy' makes pointer from integer without a cast > drivers/net/mac8390.c:254: warning: passing argument 1 of > 'word_memcpy_tocard' makes pointer from integer without a cast > drivers/net/mac8390.c:256: warning: passing argument 2 of > 'word_memcpy_fromcard' makes pointer from integer without a cast Thanks, I'll submit a patch to fix it by tomorrow or so. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ |