Prev: x86: Fix placement of FIX_OHCI1394_BASE
Next: gigaset: correct range checking off by one error
From: David Miller on 20 Mar 2010 17:30
From: Darren Jenkins <darrenrjenkins(a)gmail.com>
Date: Thu, 18 Mar 2010 19:46:48 +1100

>
> On Thu, Mar 18, 2010 at 9:10 AM, Inaky Perez-Gonzalez
> <inaky.perez-gonzalez(a)intel.com> wrote:
>
>> If krealloc() fails to aallocate a new pointer, the old block is
>> unmodified, so by doing this you are leaking a buffer allocation.
>
> It seems you are right.
> So now understanding correctly how krealloc() works I can see that the
> double kfree() can only actually happen if the el_size parameter to
> i2400m_zrealloc_2x() is zero, and it isn't at the two call sites.
>
> So this was a false positive and I am sorry for the noise.

No problem, at least the code got audited :-)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
First  |  Prev  | 
Pages: 1 2
Prev: x86: Fix placement of FIX_OHCI1394_BASE
Next: gigaset: correct range checking off by one error