Prev: [PATCH -v2] Move list types from <linux/list.h> to <linux/types.h>.
Next: 2010 Donation
From: Alan Stern on 4 Jul 2010 09:20
On Sat, 3 Jul 2010, Kulikov Vasiliy wrote:

> Use for_each_pci_dev() to simplify the code.
>
> Signed-off-by: Kulikov Vasiliy <segooon(a)gmail.com>
> ---
> drivers/usb/core/hcd-pci.c | 5 +----
> 1 files changed, 1 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/usb/core/hcd-pci.c b/drivers/usb/core/hcd-pci.c
> index 7e2d527..c1f0bba 100644
> --- a/drivers/usb/core/hcd-pci.c
> +++ b/drivers/usb/core/hcd-pci.c
> @@ -66,10 +66,7 @@ static void companion_common(struct pci_dev *pdev, struct usb_hcd *hcd,
> * vice versa.
> */
> companion = NULL;
> - for (;;) {
> - companion = pci_get_device(PCI_ANY_ID, PCI_ANY_ID, companion);
> - if (!companion)
> - break;
> + for_each_pci_dev(companion) {
> if (companion->bus != pdev->bus ||
> PCI_SLOT(companion->devfn) != slot)
> continue;

Acked-by: Alan Stern <stern(a)rowland.harvard.edu>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
 | 
Pages: 1
Prev: [PATCH -v2] Move list types from <linux/list.h> to <linux/types.h>.
Next: 2010 Donation