ext4: Fix potential quota deadlock
in [Kernel]
|
Prev: [PATCH 0/3] Regulator updates for 2.6.34
Next: [PATCH 31/97] dma-debug: Do not add notifier when dma debugging is disabled.
From: Jan Kara on 6 Jan 2010 05:50 On Wed 06-01-10 00:20:18, tytso(a)mit.edu wrote: > On Tue, Jan 05, 2010 at 03:16:27PM -0800, Greg KH wrote: > > On Tue, Jan 05, 2010 at 10:39:27PM +0100, Jan Kara wrote: > > > On Tue 05-01-10 10:56:55, Greg KH wrote: > > > > On Tue, Jan 05, 2010 at 01:47:42AM +0100, Jan Kara wrote: > > > > > On Mon 04-01-10 16:33:36, Greg Kroah-Hartman wrote: > > > > > > From: Dmitry Monakhov <dmonakhov(a)openvz.org> > > > > > > > > > > > > commit d21cd8f163ac44b15c465aab7306db931c606908 upstream. > > > > > Ted has found a serious bug in this patch over Christmas and fixed it. > > > > > Ted, do you prefer to just discard this patch or will you add your fixes? > > > > Do you have the git commit id of the patch that fixes it? > > > Commits fixing the behavior are: > > > 0637c6f4135f592f094207c7c21e7c0fc5557834 > > > ee5f4d9cdf32fd99172d11665c592a288c2b1ff4 > > > 9d0be50230b333005635967f7ecd4897dbfd181b > > > > Hm, should I add these as well, or back out all of the ext4 quota > > patches from .32 and .31? > > I don't think you need to back out all of the ext4 quota patches; Jan > has looked at the more carefully than I (since they went in via the > quota tree instead of the ext4 tree) but as far as I know the d21cd8f1 > is a standalone fix and the other patches shouldn't break if you just > drop patch #83. Adding the above mentioned patches is definitely > necessary if you include Patch #83, though, since otherwise people > mounting uncoverted ext3 filesystems using ext4 will get the BUG in > fs/ext4/inode.c:1063 regression. Yes, patch #83 is a standalone. > As far as whether it would be better to drop patch #83 or to include > these three commits, it's a bit of a toss up. If you want to play it > safe, I'd say let's drop it for now and wait for week or so, so we can > make sure the people who are testing -rc3 are happy, and for the next > stable release we can pick it up plus the additional commits listed > above. OK, reverting #83 for now and include it with other fixes later is probably the best solution. Honza -- Jan Kara <jack(a)suse.cz> SUSE Labs, CR -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ |