Prev: Security: Replace dac_mmap_min_addr to mmap_min_addr in cap_file_mmap()
Next: reiserfs: Fix corruption during shrinking of xattrs
From: Amerigo Wang on 14 Apr 2010 03:50
On Wed, Apr 14, 2010 at 03:15:14PM +0900, Tomohiro Kusumi wrote:
>Hi
>
>This patch fixes sdev_rw_attr() macro for scsi device sysfs entries.
>It seems there is no such function snscanf in the current linux kernel,

Yes! Good catch!


>so it fails to compile scsi driver when someone try to add a new rw entry.
>This has been unfixed for a long time probably because current scsi device
>has no rw entries.
>

Really? I compiled it in my configuration, but i don't see any
compile error. Hmm, i think we are lucky, no one is using the macro
sdev_rw_attr() currently.


># grep snscanf . -rn
>./drivers/scsi/scsi_sysfs.c:489: snscanf (buf, 20, format_string, &sdev->field); \
>
>Thanks,
>Tomohiro Kusumi
>
>
>
>Signed-off-by: Tomohiro Kusumi <kusumi.tomohiro(a)jp.fujitsu.com>

Acked-by: WANG Cong <xiyou.wangcong(a)gmail.com>

Thanks!
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
 | 
Pages: 1
Prev: Security: Replace dac_mmap_min_addr to mmap_min_addr in cap_file_mmap()
Next: reiserfs: Fix corruption during shrinking of xattrs