fontforge: bug in configure?
in [Ports]
|
From: Andriy Gapon on 28 Sep 2009 10:17 It seems that there is a subtle bug in fontforge's configure: CFLAGS_NOOPT=`echo $CFLAGS | sed -e s/-O2// | sed -e s/-O//` This is supposed to produce CFLAGS with all optimization options stripped. Let's leave alone the fact that there could be -O1 flag or -O3 or even -funroll-all-loops. Still, 'g' option is missing from the sed commands. Say, CFLAGS contain "-O2 ... -O2", then the first sed command would strip only the first occurrence of -O2 and the second command would leave a dangling '2'. This is what I am hitting here. Proposal: CFLAGS_NOOPT=`echo $CFLAGS | sed -e s/-O[0-9]*//g` What do you think? -- Andriy Gapon _______________________________________________ freebsd-ports(a)freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-ports To unsubscribe, send any mail to "freebsd-ports-unsubscribe(a)freebsd.org"
From: Naram Qashat on 28 Sep 2009 12:33 Andriy Gapon wrote: > It seems that there is a subtle bug in fontforge's configure: > > CFLAGS_NOOPT=`echo $CFLAGS | sed -e s/-O2// | sed -e s/-O//` > > This is supposed to produce CFLAGS with all optimization options stripped. > Let's leave alone the fact that there could be -O1 flag or -O3 or even > -funroll-all-loops. > Still, 'g' option is missing from the sed commands. > Say, CFLAGS contain "-O2 ... -O2", then the first sed command would strip only the > first occurrence of -O2 and the second command would leave a dangling '2'. > This is what I am hitting here. > > Proposal: > CFLAGS_NOOPT=`echo $CFLAGS | sed -e s/-O[0-9]*//g` > > What do you think? I'd be fine with that. I'll submit a PR for it later today. Thanks, Naram Qashat _______________________________________________ freebsd-ports(a)freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-ports To unsubscribe, send any mail to "freebsd-ports-unsubscribe(a)freebsd.org"
|
Pages: 1 Prev: yate-devel port? Next: FreeBSD Port: prelude-manager-0.9.14.2_4 |