Prev: [PATCH 14/15] sound/soc: imx: check kzalloc() result and fix memory leak
Next: (none)
From: Dave Kleikamp on 16 Jul 2010 12:40
On Fri, 2010-07-16 at 20:15 +0400, Kulikov Vasiliy wrote:
> If kmalloc() fails exit with -ENOMEM.

Looks good to me. Add my ack if you want it.

> Signed-off-by: Kulikov Vasiliy <segooon(a)gmail.com>

Acked-by: Dave Kleikamp <shaggy(a)linux.vnet.ibm.com>

> ---
> fs/cifs/readdir.c | 5 +++++
> 1 files changed, 5 insertions(+), 0 deletions(-)
>
> diff --git a/fs/cifs/readdir.c b/fs/cifs/readdir.c
> index daf1753..d5e591f 100644
> --- a/fs/cifs/readdir.c
> +++ b/fs/cifs/readdir.c
> @@ -847,6 +847,11 @@ int cifs_readdir(struct file *file, void *direntry, filldir_t filldir)
> end_of_smb = cifsFile->srch_inf.ntwrk_buf_start + max_len;
>
> tmp_buf = kmalloc(UNICODE_NAME_MAX, GFP_KERNEL);
> + if (tmp_buf == NULL) {
> + rc = -ENOMEM;
> + break;
> + }
> +
> for (i = 0; (i < num_to_fill) && (rc == 0); i++) {
> if (current_entry == NULL) {
> /* evaluate whether this case is an error */

--
Dave Kleikamp
IBM Linux Technology Center

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: Jeff Layton on 19 Jul 2010 15:00
On Fri, 16 Jul 2010 11:35:30 -0500
Dave Kleikamp <shaggy(a)linux.vnet.ibm.com> wrote:

> On Fri, 2010-07-16 at 20:15 +0400, Kulikov Vasiliy wrote:
> > If kmalloc() fails exit with -ENOMEM.
>
> Looks good to me. Add my ack if you want it.
>
> > Signed-off-by: Kulikov Vasiliy <segooon(a)gmail.com>
>
> Acked-by: Dave Kleikamp <shaggy(a)linux.vnet.ibm.com>
>
> > ---
> > fs/cifs/readdir.c | 5 +++++
> > 1 files changed, 5 insertions(+), 0 deletions(-)
> >
> > diff --git a/fs/cifs/readdir.c b/fs/cifs/readdir.c
> > index daf1753..d5e591f 100644
> > --- a/fs/cifs/readdir.c
> > +++ b/fs/cifs/readdir.c
> > @@ -847,6 +847,11 @@ int cifs_readdir(struct file *file, void *direntry, filldir_t filldir)
> > end_of_smb = cifsFile->srch_inf.ntwrk_buf_start + max_len;
> >
> > tmp_buf = kmalloc(UNICODE_NAME_MAX, GFP_KERNEL);
> > + if (tmp_buf == NULL) {
> > + rc = -ENOMEM;
> > + break;
> > + }
> > +
> > for (i = 0; (i < num_to_fill) && (rc == 0); i++) {
> > if (current_entry == NULL) {
> > /* evaluate whether this case is an error */
>

Looks good to me too.

Acked-by: Jeff Layton <jlayton(a)redhat.com>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: Steve French on 19 Jul 2010 18:00
merged into cifs-2.6.git

On Fri, Jul 16, 2010 at 11:15 AM, Kulikov Vasiliy <segooon(a)gmail.com> wrote:
> If kmalloc() fails exit with -ENOMEM.
>
> Signed-off-by: Kulikov Vasiliy <segooon(a)gmail.com>
> ---
> �fs/cifs/readdir.c | � �5 +++++
> �1 files changed, 5 insertions(+), 0 deletions(-)
>
> diff --git a/fs/cifs/readdir.c b/fs/cifs/readdir.c
> index daf1753..d5e591f 100644
> --- a/fs/cifs/readdir.c
> +++ b/fs/cifs/readdir.c
> @@ -847,6 +847,11 @@ int cifs_readdir(struct file *file, void *direntry, filldir_t filldir)
> � � � � � � � �end_of_smb = cifsFile->srch_inf.ntwrk_buf_start + max_len;
>
> � � � � � � � �tmp_buf = kmalloc(UNICODE_NAME_MAX, GFP_KERNEL);
> + � � � � � � � if (tmp_buf == NULL) {
> + � � � � � � � � � � � rc = -ENOMEM;
> + � � � � � � � � � � � break;
> + � � � � � � � }
> +
> � � � � � � � �for (i = 0; (i < num_to_fill) && (rc == 0); i++) {
> � � � � � � � � � � � �if (current_entry == NULL) {
> � � � � � � � � � � � � � � � �/* evaluate whether this case is an error */
> --
> 1.7.0.4
>
>



--
Thanks,

Steve
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
 | 
Pages: 1
Prev: [PATCH 14/15] sound/soc: imx: check kzalloc() result and fix memory leak
Next: (none)