From: Andi Kleen on 24 Jun 2010 06:00 npiggin(a)suse.de writes: > Protect d_subdirs and d_child with d_lock, except in filesystems that aren't > using dcache_lock for these anyway (eg. using i_mutex). Different locking for different file systems seems a bit confusing. Could the be unified? -Andi -- ak(a)linux.intel.com -- Speaking for myself only. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Nick Piggin on 24 Jun 2010 12:00
On Thu, Jun 24, 2010 at 11:50:17AM +0200, Andi Kleen wrote: > npiggin(a)suse.de writes: > > > Protect d_subdirs and d_child with d_lock, except in filesystems that aren't > > using dcache_lock for these anyway (eg. using i_mutex). > > Different locking for different file systems seems a bit confusing. > Could the be unified? Yes well it is a bit misleading. It should always be modified under spinlocks, but some filesystems are using i_mutex for read access, which should be fine (and not require knowledge of any other code). -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ |